Re: Please stop committing on a broken build! ([Testbot] Plone 5.0 - Python 2.7 - Build # 1925 - Regression! - 6 failure(s))

On 3/13/14, 12:40 PM, Rok Garbas wrote:
> Quoting David Glick (Plone) (2014-03-13 16:15:57)
>> On 3/13/14, 6:21 AM, Timo Stollenwerk wrote:
>>> Hi,
>>>
>>> the Plone 5 build is pretty broken (~60 broken tests, including almost
>>> all robot tests) since yesterday (see commit below).
>>>
>>> If I'm not mistaken, this is due to the merge of the csfr PLIP and I
>>> guess Nathan is working on fixing things.
>> Actually I think all the robot failures were due to the packages Rok
>> updated in mockup yesterday, which caused a problem in the plone bundle.
>> I made a fix last night.
>>
>> I am really hoping we have the tests passing by the end of the day
>> today, so that we have a green build heading into the Emerald Sprint
>> tomorrow.
>>
> sry guys, i was updating packages (only minor versions) and tested that mockup
> tests pass which i see wasn't enough. tnx davisagli for the fix.
>
> i would like to stay up to date with packages, so we don't fall behind like
> with did with jquery (rember we were using 1.4 just one year ago :P). i'll be
> more carefull when doing this next time (also checking that i don't break
> jenkins builds for plone5). also sending email to this mailing list might help,
> since it can take quite some time for tests to finish and i might need to go to
> bed in the meantime.
>
>
> @tisto: its first time i broke build just by touching js in mockup. means that
> whole chain of ... commiting to mockup -> building bundles on travis -> travis
> commits to CMFPlone -> which triggers jenkins job and runs plone tests ...
> kinda works. you think this whole chain is to fragile? should we already start
> thinking how to optimize this?
>
Yes, I think the conclusion here is actually quite positive: A 
javascript update broke Plone, and our testing setup helped us catch and 
fix it within a day.

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech