Re: Please stop committing on a broken build! ([Testbot] Plone 5.0 - Python 2.7 - Build # 1925 - Regression! - 6 failure(s))
"David Glick (Plone)" <david.glick-z4DKO/[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <[email protected]> |
The testBrowserDefault failures were a difference in how the html was getting normalized. I think they passed for you locally because you have a different libxml2 than the jenkins server (same reason the diazo tests fail for you locally). I may have fixed this but we'll see what jenkins says. The 'select default page' robot tests were failing because the default page was being initially set in a way that failed the auto-csrf check. I'm not sure why it passed locally. Also should be fixed. I haven't figured out the plone.app.customerize failure. On 3/13/14, 9:57 PM, Asko Soukka wrote: > This failing robot portlet test might be CSRF-related: > > http://jenkins.plone.org/job/plone-5.0-python-2.7/1953/robot/report/robot_log.html#s1-s6-t1-k4-k1-k1 > > OTOH, these folder default page robot issues are most probably unrelated > and just "timing" issues: > > http://jenkins.plone.org/job/plone-5.0-python-2.7/1953/robot/report/robot_log.html#s1-s11-t8-k4-k3-k1 > > Probably there should be a wait between those clicks, e.g. > > Element should be visible id=folderChangeDefaultPage > > or > > Wait until element is visible id=folderChangeDefaultPage > > -Asko > > Nathan Van Gheem wrote: >> If anyone else can take a look, I'm pretty certain all remaining test >> failures have nothing to do with the CSRF merge. >> >> http://jenkins.plone.org/job/plone-5.0-python-2.7/lastCompletedBuild/testReport/ >> >> I can't reproduce the Products.CMFPlone.tests.testBrowserDefault.* or >> plone.app.customerize and the robot tests are sporadic for me. >> >> >> On Thu, Mar 13, 2014 at 5:04 PM, Rok Garbas <[email protected] >> <mailto:[email protected]>> wrote: >> >> > > > Yes, I think the conclusion here is actually quite positive: A >> > > > javascript update broke Plone, and our testing setup helped >> us catch and >> > > > fix it within a day. >> > > >> > > and i have to buy a cake! :) >> > >> > Not all of us eat cake. I propose whisky :) delivered direct to >> next available >> > sprint :) >> > >> > FYI this is very similar to the film industry, at least in >> Australia. If your >> > phone goes off during a take you have to buy a case of beer for >> the rest of the >> > crew. >> > >> >> ok, rum on this island is much better. legendario (cuban) rum it is >> then. but >> we have to rename the sprint then. Wine, Beer and Rum sprint :) see >> you all >> there. >> >> >> -- >> Rok Garbas - http://www.garbas.si >> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book >> "Graph Databases" is the definitive new guide to graph databases and >> their >> applications. Written by three acclaimed leaders in the field, >> this first edition is now available. Download your free book today! >> http://p.sf.net/sfu/13534_NeoTech >> _______________________________________________ >> Plone-developers mailing list >> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org >> <mailto:Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> >> https://lists.sourceforge.net/lists/listinfo/plone-developers >> >> >> >> >> -- >> Nathan Van Gheem >> Solutions Architect >> Wildcard Corp >> >> ------------------------------------------------------------------------------ >> Learn Graph Databases - Download FREE O'Reilly Book >> "Graph Databases" is the definitive new guide to graph databases and their >> applications. Written by three acclaimed leaders in the field, >> this first edition is now available. Download your free book today! >> http://p.sf.net/sfu/13534_NeoTech >> >> _______________________________________________ >> Plone-developers mailing list >> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org >> https://lists.sourceforge.net/lists/listinfo/plone-developers > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > Plone-developers mailing list > Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/plone-developers ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech