Re: Throw event after localroles changed

Am 19.03.2014 02:09, schrieb Sean Upton:
> On Mon, Mar 17, 2014 at 3:29 PM, Johannes Raggam <[email protected]> wrote:
>> sounds like a good idea for me.
>>
>> at some point, it might make sense to move reindexObjectSecurity to an
>> event handler, which listens for the new LocalrolesModifiedEvent.
> +1 to both Robert's original idea and to moving indexing to a handler
> (only, keep in mind any side-effects from being unable to control
> subscriber order, in case a handler needs to run after re-indexing).
> I could use notification of some event in collective.teamwork (which
> creatively re-uses the sharing view) -- seems useful for audit-trail
> purposes, etc.
reindexObjectSecurity gets called explicit and only if localroles 
changed in handle form. I think that's pretty clean that way and moving 
this call out to a subscriber might end up in unexpected behavior unless 
we're introducing 2 events. I don't think we want it that way.

I'll add the event for now and leave reindexObjectSecurity call where it 
is, it could be moved later once a clean proposal how to ensure 
reliability can be achieved has been made.

Robert

>
> Sean


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech