Re: Please stop committing on a broken build! ([Testbot] Plone 5.0 - Python 2.7 - Build # 1925 - Regression! - 6 failure(s))
Nathan Van Gheem <[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <CAL8hw9HA6Jyrr-8m4z+qnR1dWLQbfdfGsbuJ=vj+hiUYZyKiVw@mail.gmail.com> |
Thanks for the call-out. I can't reproduce with a fresh live site and none of the robot tests run correctly ever for me on my machine. I don't have time to mess with it. On Thu, Mar 20, 2014 at 3:03 PM, Timo Stollenwerk <tisto-z4DKO/[email protected]> wrote: > Am 14.03.2014 04:10, schrieb Nathan Van Gheem: > > If anyone else can take a look, I'm pretty certain all remaining test > > failures have nothing to do with the CSRF merge. > > > > > http://jenkins.plone.org/job/plone-5.0-python-2.7/lastCompletedBuild/testReport/ > > The failing robot test seems to be CSRF related (see screenshot): > > > http://jenkins.plone.org/job/plone-5.0-python-2.7/2006/robot/report/robot_log.html#s1-s6 > > In any case, the person who broke the build is responsible to make it > green again. :) > > This is why it is so important not to commit on a broken build. Every > commit on a broken build makes it harder to figure out which commit > broke which test. > > Cheers, > Timo > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > Plone-developers mailing list > Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/plone-developers > -- Nathan Van Gheem Solutions Architect Wildcard Corp ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Plone-developers mailing list Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/plone-developers