Re: Please stop committing on a broken build! ([Testbot] Plone 5.0 - Python 2.7 - Build # 1925 - Regression! - 6 failure(s))

I would be very frustrated if you reverted all the work I did. The CSRF
plip affected a lot of packages and was a decent amount of work. I won't
bother doing it again. Also, a different commit broke tests at the same
time I was pushing my changes.

The plone 4.2 and 4.3 builds have been broken for quite some time without
anybody getting all up in arms about it.


On Fri, Mar 21, 2014 at 3:01 AM, Anthony Gerrard
<[email protected]>wrote:

> Our docs say that changes that break the build should be reverted
>
> "If the build is broken over a longer period of time (more than a couple
> of hours) you should either notify the developer who is responsible for the
> breakage, fix the problem yourself, or just revert the commit in order to
> be able to continue to work."
>
>
>
> On 21 March 2014 07:38, Laurence Rowe <[email protected]> wrote:
>
>> We can't just merge features and then keep the build broken for weeks.
>>>  People are committing anyways, breaking more stuff without notice and in
>>> the end someone has to clean up that mess. The longer we keep the build
>>> broken the harder it gets...
>>>
>>> I try to keep track and remind people if they break things, but that
>>> only works well if the build is green in the first place.
>>
>>
>> Would it be possible to get tests running on feature branches as well as
>> master / version branches? It seems unavoidable that occasionally checkins
>> will break the build, but if those checkins are always made to a feature
>> branch and merging of the feature to master happens only after looking at
>> the build status then master should stay green. (Ideally one first merges
>> from master to the feature branch to ensure the merge back is clean.)
>>
>> I realise the above is very tricky for a system as complex as Plone, but
>> I've found it to be a great help in my (much smaller) current project.
>>
>> Laurence
>>
>>
>> ------------------------------------------------------------------------------
>> Learn Graph Databases - Download FREE O'Reilly Book
>> "Graph Databases" is the definitive new guide to graph databases and their
>> applications. Written by three acclaimed leaders in the field,
>> this first edition is now available. Download your free book today!
>> http://p.sf.net/sfu/13534_NeoTech
>> _______________________________________________
>> Plone-developers mailing list
>> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>> https://lists.sourceforge.net/lists/listinfo/plone-developers
>>
>>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/13534_NeoTech
> _______________________________________________
> Plone-developers mailing list
> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/plone-developers
>
>


-- 
Nathan Van Gheem
Solutions Architect
Wildcard Corp

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers