Re: Please stop committing on a broken build! ([Testbot] Plone 5.0 - Python 2.7 - Build # 1925 - Regression! - 6 failure(s))

Am 21.03.2014 09:15, schrieb Nathan Van Gheem:
> I would be very frustrated if you reverted all the work I did. The CSRF
> plip affected a lot of packages and was a decent amount of work. I won't
> bother doing it again. Also, a different commit broke tests at the same
> time I was pushing my changes.

PLIPs are somehow special in that regard. Since PLIPs consist of many
different branches, it is hard to foresee all test failures before
actually merging it. In addition it is sometimes non-trivial to revert
those commits.

Also, as Nathan mentioned, other people were committing breaking more
things (this is why I wrote my mail in the first place). We all have to
take the CI rules more seriously and I hope we can improve the CI setup
in the future to make it more obvious if people break those CI rules.

> The plone 4.2 and 4.3 builds have been broken for quite some time
> without anybody getting all up in arms about it.

This is because Eric's commit broke the build by checking out packages
that had failures, so it wasn't really Eric's fault but the fault of the
developers that forgot to add the packages they worked on to
auto-checkout. This is also something that we have to think about how to
prevent in the future.

Cheers,
Timo


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech