Re: Pull-Request Crusade [was Re: [Products.Archetypes] Correctly...]

On 14 May 2014, at 4:53 pm, Jean Jordaan <[email protected]> wrote:

> On Wed, May 14, 2014 at 8:09 AM, Dylan Jay <djay-n0pU0XVUApFWk0Htik3J/[email protected]> wrote:
>> On 13 May 2014, at 5:30 pm, Jens W. Klein <jens-/[email protected]> wrote:
>>> 
>>> So help appreciated - and if its just a short comment from people deeper
>>> into the package.
> 
> I'd like to devote time to this ... but usually just get exhausted.
> 
>>> I think looking at pull-requests (and issues) is also a good and needed
>>> sprint topic - imo it must be a topic on every future Plone Sprint.
> 
> That's a good idea. There may even be pending PRs relevant to the sprint
> topic. But there must be online momentum as well. Community service PR
> gardening.
> 
>>> As a contributor/requester it must be completly disapointing: One has
>> 
>> As someone who some of those pull request belong to, it is disappointing.
> 
> I recently fixed a valid prematurely-closed ticket from 4 years ago
> (naturally after being bitten by the issue myself):
>  https://dev.plone.org/ticket/11150
> 
> I don't know why kleist "defected" but there's a lot of open issues from
> him in the tracker.
> 
>> It's not an easy thing to fix. Who's job is it to review pull requests?
> 
> Well, anyone with commit access is eligible, but yes how to alert the best
> people for the PR. I like your (Dylan) suggestion (find and hassle). Perhaps we
> should have an "orphan PR" label. When a reviewer responds, the label can be
> removed and the issue is considered adopted.  Then FWT or release manager
> can look for old "orphan PR" issues and try to find a reviewer. If the
> adopter of
> a PR finds that they can't handle it in time, they could add back the
> "orphan PR"
> label.

Another idea I'd previously floated is a @plonedev github account that emails either the plone-dev list or another list. That way if the contributor doesn't have to know who to ask to review they have a good default choice. However that still puts the responsibility of hassling for a review on the contributor, not on the rest of the community, particularly if it's a large list of people and everyone just things someone else will pick it up.


> 
> -- 
> jean                                              . .. .... //\\\oo///\\


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs