Re: mr.roboto and Jenkins false positives

On Sun, 2014-06-08 at 09:05 +0200, Timo Stollenwerk wrote:
> Am 06.06.2014 23:24, schrieb Sean Upton:
> > I am having another issue with mr.roboto -- not sure why mr.roboto is
> > blaming a commit [1] when neither (a) jenkins lists "no changes" for
> > that build run; (b) the commit was clearly not included in the build
> > (tracebacks make that painfully obvious, the commit in question
> > actually fixes the regression in a previous build).
> 
> One of our major problems and reasons why we started mr.roboto was that
> it is quite hard to get the correct git commit message into the Jenkins
> build. mr.roboto can not use the standard CHANGES link in Jenkins, at
> least not without writing Java code. This is confusing and I would love
> to fix that. The problem is that Jenkins and its github plugin can not
> handle multiple git repositories. As soon as there is more than one
> repository all commit messages are gone.
> 
> > Is there a way to (a) make mr.roboto a bit smarter on this kind of
> > false positive; (b) re-trigger the jenkins python-2.6 build without
> > committing anything?
> 
> (a) I guess that would be quite hard because there are a thousand things
> that can go wrong.
> 
> (b) As said in my previous mail. We have to setup LDAP to allow people
> to re-trigger any Jenkins build.

Is the missing LDAP Integration also the reason, why no username for the
person who started the jenkins build by commiting something is shown?

I'm asking myself if there isn't a better solution than Jenkins for our
Continuous Integration requirements. Jenkins UI and UX are less than
ideal and it seems hard to be adopted to specific requirements.

Does someone have some experience with Buildbot? Google and Mozilla are
using it for really big projects and it's written in Python. The website
claims, that one major outstanding difference to other CI systems is
it's adaptability to user requirements.

If Jenkins is so hard to integrate in a way, that it fit our needs, we
should think about an alternative. I'd guess, doing the basic work for
changing the CI infrastructure could be within the scope of a sprint.


With that chance, maybe we can even change our CI best practices to only
accept pull-requests. What about this idea: When a pull-request is
submitted (and after an obligatory code-review step) the CI test suite
is kicked off. If the build fails, the pull request is revoked.
Otherwise merged. This would give us an environment with atomic
transactions/merges, where the tests are guaranteed to pass all the
time, because only "green" pull-requests are merged.


When and where is the CI sprint planned? I'm interested to participate,
but I'm very short on time this year, so I have to plan in advance.


Johannes



> 
> Cheers,
> Timo
> 
> > 
> > [1]  https://github.com/plone/plone.supermodel/commit/504f367b85016454ba1e73dc46160992b25b2c85#commitcomment-6587475
> > 
> > On Mon, Jun 2, 2014 at 1:15 PM, Sean Upton <[email protected]> wrote:
> >> It looks like there was some kind of temporary condition on whatever
> >> build slave is used for Plone 4.3 / Python 2.6 that caused these
> >> issues:
> >>
> >>   http://jenkins.plone.org/job/plone-4.3-python-2.6/2109/testReport/
> >>
> >> These were unrelated to changes preceding the build, and were also
> >> evident in the previous
> >> http://jenkins.plone.org/job/plone-4.3-python-2.6/2108/
> >>
> >> These were also cleared in the next build --
> >> http://jenkins.plone.org/job/plone-4.3-python-2.6/2110/
> >>
> >> This brings two questions:
> >>
> >> 1. What should be the protocol for handling the false-positive
> >> automated comments mister-roboto places on github commits (e.g. [1])?
> >> Should they merely be responded to, or deleted?
> >>
> >> 2. Is there any way mr.roboto can be modified to omit blame for a
> >> broken build if the previous build (prior to a commit) was broken for
> >> the same reasons?
> >>
> >> Sean
> >>
> >> [1] https://github.com/plone/plone.supermodel/commit/f16f480b6062a44bda6f729f03de4555c65c82b0#commitcomment-6508044
> > 
> > ------------------------------------------------------------------------------
> > Learn Graph Databases - Download FREE O'Reilly Book
> > "Graph Databases" is the definitive new guide to graph databases and their 
> > applications. Written by three acclaimed leaders in the field, 
> > this first edition is now available. Download your free book today!
> > http://p.sf.net/sfu/NeoTech
> > _______________________________________________
> > Plone-developers mailing list
> > Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/plone-developers
> > 
> 
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their 
> applications. Written by three acclaimed leaders in the field, 
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/NeoTech
> _______________________________________________
> Plone-developers mailing list
> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/plone-developers

-- 
programmatic  web development
di(fh) johannes raggam / thet
python plone zope development
plone framework  team  member
mail: office-//[email protected]
web:  http://programmatic.pro
      http://bluedynamics.com

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://www.hpccsystems.com

_______________________________________________
Plone-developers mailing list
Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/plone-developers

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlOVkkIACgkQW4mNMQxDgAfDNQCgjUZR6vqECk5qC4ArgD17up/Q
YhcAn0dHVCQEcbl0O8WJdy7TioD5ScyZ
=TL24
-----END PGP SIGNATURE-----