Re: Broken build since four days
Timo Stollenwerk <tisto-z4DKO/[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Message-ID | <[email protected]> |
Am 24.06.2014 11:27, schrieb Jens W. Klein: > On 2014-06-23 09:28, Timo Stollenwerk wrote: >> Am 21.06.2014 09:12, schrieb Timo Stollenwerk: > [..] >>> >>> We have lots of new Jenkins slave machines ready to put into production >>> and this broken build is keeping us from being able to use them. I can't >>> fully test the new machines if not all builds are green. >> >> The Plone 5 AT job is green now: > > Thanks Timo for figuring this out. I had no time until now to look at it. > >> http://jenkins.plone.org/job/plone-5.0-python-2.7-at/1548/ >> >> This pull request merge introduced the test failures: >> >> https://github.com/plone/Products.Archetypes/commit/a6abb32f7ea2c6a4c830306c816ec591c90b13bb > > This is really bad, since mr.roboto told in there jenkins tests are > green. If this is not working correctly its better to not tell about > testing at all on PR. This is a known problem. It occurs when a package is changed that is not in auto-checkout. Jenkins then runs the tests against the lastest version that is declared in buildout.coredev/mr.developer. So far we require the developers to take care of that (which obiously does not work well). Though, we need a solution to either automatically add such a package to auto-checkout or fail the build. My todo list is pretty long these days though...help would be more than welcome. >> I amended the tests accordingly. Please double check. >> >> The Grok problem still persists. > > This is out of scope of the merged pull requests. Why do we test grok at > all? It should be an addon only. We don't. Your commits/pull request merges somehow introduced a grok dependency into the build and the alltests script runs all tests in the build. I did a quick check and removed plone.app.linkintegrity from auto-checkout and used a released version. With that in place there were no grok tests. Therefore there has to be something in p.a.linkintegrity that fetches grok. I will try to double check later today. Though, I'm on my way to a conference, so I won't have much time until next week. Cheers, Timo ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft