Re: Products.CMFEditions pull request not triggering mr.roboto

Hi Rafael,

Am 24.07.14 18:54, schrieb Rafael Oliveira:
> Hi,
>
> I made a pull request to Products.CMFEditions [1]. According to the
> rules stated on the coredev docs [2] I expected it to trigger
> mr.roboto tests, but I've got no comment on GitHub nor e-mail about
> the test results. I can see that are other pull requests in the past
> that triggered mr.roboto, such as [3].

The documentation is not accurate. We somehow implemented those pull 
request tests, but they never actually worked.

@Ramon: Could you remove that paragraph from the docs?

> Can anyone help me on this ? I'd like some validation before
> proceeding to merge the pull request.

You can either manually merge the pull request on the command line and 
run all coredev tests or just go ahead and merge the pull request and 
then revert if necessary. It is perfectly ok to break the build if you 
revert your commit immediately in case you break the build.

If you have trouble running the buildout coredev tests I can check your 
pull request manually as well.

We hope to improve that situation in the future, but this is all we got 
right now...

Timo

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds