Proposal: specific permission for history view/viewlet

Luca Fabbri <[email protected]>
Newsgroups gmane.comp.web.zope.plone.devel
Message-ID <CAGfGq=agZX7+NVKufGtWoggCkNa+n2At25GLWOOh=DNa1ihw0Q@mail.gmail.com>
I'd like to implement a change to the core, but want to know if this
can be acceptable before spending time into this.

Right now the history viewlet is showing two kind of information: the
workflow history and the versioning history.

While the access to latter list is protected by the "CMFEditions:
Access previous versions" permission, the access to the workflow
history use a combination of two permissions: "Review portal content"
and "Request review".
See https://github.com/plone/plone.app.layout/blob/42a638d3fb3137bb4886e8e5173d5ec6f8b2e6ec/plone/app/layout/viewlets/content.py#L205

I never liked this choice too much because can be ok only for Plone
default workflows but it became quickly tricky for 3rd party workflow
with additional roles.
Customizing it means override a very big method of the viewlet, just
for changing one line of code (another lightweight change can be to
move the permission check in another method, easily customizable).

What about adding a new permission just for accessing this information?
If you like this, I need some suggestion about:
* how to call this new permission
* where put it (in which plone.something or Products.something package)

Finally: I'd like to see this in both Plone 4.3 and Plone 5.

-- 
-- luca

twitter: http://twitter.com/keul
linkedin: http://linkedin.com/in/lucafbb
blog: http://blog.keul.it/

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.