Re: broken jenkins and PloneTestCase magic
"Jens W. Klein" <jens-/[email protected]>
| Newsgroups | gmane.comp.web.zope.plone.devel |
|---|---|
| Organization | Klein & Partner KG |
| Message-ID | <[email protected]> |
On 2014-12-03 11:33, Timo Stollenwerk wrote: > Am 03.12.2014 um 09:48 schrieb Jens W. Klein: >> I love the smell of a red jenkins in the morning... >> >> Yesterday I broke the build - but I do not revert that fats ;) maybe one >> of you now how to fix this. > > Please revert if you can not fix this today. This blocks the development > for everybody who sticks with the CI rules. It is not too hard to create > a branch and then just revert. > >> plone.app.upgrade has a problem. It uses deprecated Products.PloneTestCase. > > See: > > https://github.com/plone/Products.CMFPlone/issues/234 > > What if we would just remove (or disable) tests for old Plone versions > and just keep the latest ones? We are not going to change any upgrade > steps for older Plone versions (e.g. Plone 3.3.2 -> 3.3.3), right? > > Therefore we do not really need to test those any longer, or am I > missing something here? This way users can still migrate from 2.5 to 5.0 > and we lower the amout of work that is necessary to move tests to > p.a.testing. Sounds sane to me. I digged a bit through the testing code of plone.app.upgrade and really didnt get it whats going on there: We have plone.app.upgrade.tests.base.MigrationTestCase which https://github.com/plone/plone.app.upgrade/blob/master/plone/app/upgrade/tests/base.py#L26 which is a old school deprecated PloneTestCase. It is used as base class for all - also plone 5 plone.app.testing layer using - migrations. Also in this file on module level a setupPloneSite() is called. Why does it work? This packages testing story is a complete nightmare. Jens -- Klein & Partner KG, member of BlueDynamics Alliance ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk