Re: split of mockup / plone.mockup

Hi Johannes,

making mockup installable via bower is a worthwile goal.  Thanks for 
working on that!

Though, I see a problem with using git submodules. It is already quite 
hard to create a proper CI setup on top of mr.developer, and using git 
submodules will make this even harder. Here is why:

We are basically nesting our development packages into our main 
repository with mr.developer. This makes it hard to impossible to 
trigger one Jenkins job per commit (we tried very smart stuff with 
mr.roboto and we failed miserably, you have to store every single hash 
value and every version pinning for each pkg and re-run buildout with 
this). We are still aiming for 1 commit = 1 build. Though, adding a 
second nested level (git submodules) within our already nested setup 
will make this impossible. We might be able to somehow pin our modules 
if we do releases in the future. We are not going to be able to do this 
in a structure that is nested twice.

Futhermore, my personal experience with git submodules is that even when 
working with in manually, it is nothing but unpredictable pain.

In addition to the uncertainty that buildout and mr.developer already 
put into our CI setup, you just introduced another one.

I think we should try to find another way to solve this problem. I'm not 
sure if we still take "mockup should be used outside Plone" seriously. 
Though, in any case I think we should test and release mockup 
separately. What if the mockup CI system (travis?) creates a new release 
if all unit tests pass. The Plone CI could pick up the latest release 
and we would just have to make sure the travis job triggers the Jenkins 
CI. Plone would just install the latest mockup development version via 
bower.

Though, this setup only make sense if we start to write proper 
acceptance tests for mockup. No matter what Rok might have told you ;), 
we do not have any acceptance tests to make sure mockup works within 
Plone (at least as far as I know, the only two tests that we have, were 
written by Gil and me at the Cathedral sprint).

Cheers,
Timo

Am 08.03.15 um 22:26 schrieb Johannes Raggam:
> I refactored mockup today, so that the Python packaging related code is
> in plone.mockup and mockup is installable via bower again. plone.mockup
> is the new mockup integration package for Plone 5. It uses git
> submodules to pull the mockup repository.
>
> This is the story behind this change:
>
> The mockup repository was restructured after the Plone conf in order to
> be able to create eggs out of it. Therefore, all relevant content was
> moved into the mockup sub directory. But since then, mockup couldn't be
> properly installed via bower. Installing mockup with bower doesn't
> install any of it's dependencies, because bower.json is not in the top
> level directory. Moving bower.json, package.json, Gruntfile.js and
> Makefile to the top level directory doesn't help much, because
> mockup-core is expecting a specific directory layout and would have to
> be patched in order to work with another directory layout. This was
> actually my first attempt, but I gave it up because one error lead to
> another.
> Therefore I tried another path and created plone.mockup, which is a
> Python package, which pulls mockup via the git submodules featue. I
> know, git submodules are known to be nasty, but here it helps to solve
> the issue of mockup not being a proper bower/npm package.
>
> Why would I depend on mockup in another bower package? I want to create
> a custom bundle for Plone 4, which includes the mockup widgets bundle
> and some custom JavaScript for a client project.
>
>
> I hope you're all O.K. with that.
>
>
> Cheers, Johannes
>
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming The Go Parallel Website, sponsored
> by Intel and developed in partnership with Slashdot Media, is your hub for all
> things parallel software development, from weekly thought leadership blogs to
> news, videos, case studies, tutorials and more. Take a look and join the
> conversation now. http://goparallel.sourceforge.net/
>
>
>
> _______________________________________________
> Plone-developers mailing list
> Plone-developers-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/plone-developers
>

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/