Re: [Plone-developers] Fixing LinguaPlone bug 243 - Where to put patch
| Newsgroups | gmane.comp.web.zope.plone.internationalization |
|---|---|
| Message-ID | <6fd50e7b054c1cfa88260649f0d09a8d@localhost> |
On Sat, 12 Jun 2010 13:37:02 +0200, Hanno Schlichting <[email protected]> wrote: > Hi. > > Discussions about LinguaPlone preferably happen on the plone-i18n > mailing list [1]. It's not part of Plone Core after all. OK, here we go. > On Sat, Jun 12, 2010 at 1:19 PM, <[email protected]> wrote: >> I discovered a bug in LinguaPlone, bug number 243: >> >> http://plone.org/products/linguaplone/issues/243 > > I've seen your report, but you suggested patch is quite certainly not > optimal. It would be helpful if you added version information (Plone 3 > vs Plone 4, which version of LinguaPlone) to the report. The exact > place to look for the language in the request has changed between the > two versions and also the folder contents view code changed a bit. The > getFolderContents script in Plone 4 doesn't look at the request at all > anymore for example. Yep, version info added. I've thought a bit more about the patch; I've looked at another Plone site which is 3.0.6 and that also has portal_languages available. That other site does not have LinguaPlone installed, and there is no Language index or metadata, so it seems safe enough to add Language as a content filter. -Morten ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo