Re: i18ndude: wrap long lines

--===============5827515891032788170==
Content-Type: multipart/alternative; boundary=047d7b111f3be318c304e5cc1e1c

--047d7b111f3be318c304e5cc1e1c
Content-Type: text/plain; charset=ISO-8859-1

Hi Maurits,

The change is ok for me. You are now owner on pypi.

Vincent Fretin
Ecreall
http://www.ecreall.com


On Sat, Sep 7, 2013 at 4:29 PM, Maurits van Rees <m.van.rees-1kr/[email protected]
> wrote:

> Hi,
>
> I have committed changes for i18ndude that wrap long lines in msgids and
> msgstrs, as most PO editors do that.  See this issue:
> https://github.com/collective/i18ndude/issues/3
>
> You can switch this off to get the original behavior back by setting an
> environment variable when calling i18ndude:
>
> PO_MAX_WIDTH=0 i18ndude ...
>
> (This could be made a proper command line option, but it seems best to
> first refactor the script to using argparse instead of directly reading
> sys.argv in all the commands.)
>
>
> Question: does anyone foresee problems with this change for the core
> Plone translations?
>
> Of course the first time this new version is used you would get a really
> long diff.  After that it should be fine.  If a translator keeps
> everything on one line or does not manually split the lines perfectly
> (which is probably hard without a custom po editor), then the next time
> i18ndude is called it will shift some words to other lines, giving more
> line differences.  On the plus side, someone fixes a typo in a long
> msgid or msgstr, this is easier to notice in a 80 character line than in
> a 1000 character line.
>
>
> On another note, the current release 3.2.2 is almost three years old, so
> a new release would be good.  From the changelog since then:
>
> - Wrap msgid and msgstr lines at 79 characters, as most PO editors do
>    that.  Set an environment variable ``PO_MAX_WIDTH`` to choose a
>    different length.  If this is two or less, we do no wrapping,
>    because all lines must be enclosed in quotes.
>    https://github.com/collective/i18ndude/issues/3
>    [maurits]
>
> - Return exit code 1 when the called function gives an error.  This
>    currently only has an effect when calling ``find-untranslated``.
>    https://github.com/collective/i18ndude/issues/1
>    [maurits]
>
> - Moved code to https://github.com/collective/i18ndude
>    [maurits]
>
> - Backslash escape added to msgid when it includes double quotes.
>    [taito]
>
> - Add trmerge command to merge po files. Custom tailored for transifex.
>    [do3cc]
>
>
> Could I get release rights on pypi and plone.org?  My username is
> maurits in both cases.  PyPI owners are: hannosch, nouri, vincentfretin.
>   Or make a release yourself at your convenience.
>
> Best,
>
> --
> Maurits van Rees: http://maurits.vanrees.org/
> Zest Software: http://zestsoftware.nl
>
>
>
> ------------------------------------------------------------------------------
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
> _______________________________________________
> Plone-i18n mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/plone-i18n
>

--047d7b111f3be318c304e5cc1e1c
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div>Hi Maurits,<br><br></div>The change is ok for me=
. You are now owner on pypi.<br></div><div class=3D"gmail_extra"><br clear=
=3D"all"><div><div dir=3D"ltr">Vincent Fretin<br>Ecreall<br><a href=3D"http=
://www.ecreall.com" target=3D"_blank">http://www.ecreall.com</a></div>

</div>
<br><br><div class=3D"gmail_quote">On Sat, Sep 7, 2013 at 4:29 PM, Maurits =
van Rees <span dir=3D"ltr">&lt;<a href=3D"mailto:m.van.rees-1kr/[email protected]=
" target=3D"_blank">m.van.rees-1kr/[email protected]</a>&gt;</span> wrote:<br><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #=
ccc solid;padding-left:1ex">

Hi,<br>
<br>
I have committed changes for i18ndude that wrap long lines in msgids and<br=
>
msgstrs, as most PO editors do that. =A0See this issue:<br>
<a href=3D"https://github.com/collective/i18ndude/issues/3" target=3D"_blan=
k">https://github.com/collective/i18ndude/issues/3</a><br>
<br>
You can switch this off to get the original behavior back by setting an<br>
environment variable when calling i18ndude:<br>
<br>
PO_MAX_WIDTH=3D0 i18ndude ...<br>
<br>
(This could be made a proper command line option, but it seems best to<br>
first refactor the script to using argparse instead of directly reading<br>
sys.argv in all the commands.)<br>
<br>
<br>
Question: does anyone foresee problems with this change for the core<br>
Plone translations?<br>
<br>
Of course the first time this new version is used you would get a really<br=
>
long diff. =A0After that it should be fine. =A0If a translator keeps<br>
everything on one line or does not manually split the lines perfectly<br>
(which is probably hard without a custom po editor), then the next time<br>
i18ndude is called it will shift some words to other lines, giving more<br>
line differences. =A0On the plus side, someone fixes a typo in a long<br>
msgid or msgstr, this is easier to notice in a 80 character line than in<br=
>
a 1000 character line.<br>
<br>
<br>
On another note, the current release 3.2.2 is almost three years old, so<br=
>
a new release would be good. =A0From the changelog since then:<br>
<br>
- Wrap msgid and msgstr lines at 79 characters, as most PO editors do<br>
=A0 =A0that. =A0Set an environment variable ``PO_MAX_WIDTH`` to choose a<br=
>
=A0 =A0different length. =A0If this is two or less, we do no wrapping,<br>
=A0 =A0because all lines must be enclosed in quotes.<br>
=A0 =A0<a href=3D"https://github.com/collective/i18ndude/issues/3" target=
=3D"_blank">https://github.com/collective/i18ndude/issues/3</a><br>
=A0 =A0[maurits]<br>
<br>
- Return exit code 1 when the called function gives an error. =A0This<br>
=A0 =A0currently only has an effect when calling ``find-untranslated``.<br>
=A0 =A0<a href=3D"https://github.com/collective/i18ndude/issues/1" target=
=3D"_blank">https://github.com/collective/i18ndude/issues/1</a><br>
=A0 =A0[maurits]<br>
<br>
- Moved code to <a href=3D"https://github.com/collective/i18ndude" target=
=3D"_blank">https://github.com/collective/i18ndude</a><br>
=A0 =A0[maurits]<br>
<br>
- Backslash escape added to msgid when it includes double quotes.<br>
=A0 =A0[taito]<br>
<br>
- Add trmerge command to merge po files. Custom tailored for transifex.<br>
=A0 =A0[do3cc]<br>
<br>
<br>
Could I get release rights on pypi and <a href=3D"http://plone.org" target=
=3D"_blank">plone.org</a>? =A0My username is<br>
maurits in both cases. =A0PyPI owners are: hannosch, nouri, vincentfretin.<=
br>
=A0 Or make a release yourself at your convenience.<br>
<br>
Best,<br>
<br>
--<br>
Maurits van Rees: <a href=3D"http://maurits.vanrees.org/" target=3D"_blank"=
>http://maurits.vanrees.org/</a><br>
Zest Software: <a href=3D"http://zestsoftware.nl" target=3D"_blank">http://=
zestsoftware.nl</a><br>
<br>
<br>
---------------------------------------------------------------------------=
---<br>
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!<br>
Discover the easy way to master current and previous Microsoft technologies=
<br>
and advance your career. Get an incredible 1,500+ hours of step-by-step<br>
tutorial videos with LearnDevNow. Subscribe today and save!<br>
<a href=3D"http://pubads.g.doubleclick.net/gampad/clk?id=3D58041391&amp;iu=
=3D/4140/ostg.clktrk" target=3D"_blank">http://pubads.g.doubleclick.net/gam=
pad/clk?id=3D58041391&amp;iu=3D/4140/ostg.clktrk</a><br>
_______________________________________________<br>
Plone-i18n mailing list<br>
<a href=3D"mailto:[email protected]">[email protected]=
forge.net</a><br>
<a href=3D"https://lists.sourceforge.net/lists/listinfo/plone-i18n" target=
=3D"_blank">https://lists.sourceforge.net/lists/listinfo/plone-i18n</a><br>
</blockquote></div><br></div></div>

--047d7b111f3be318c304e5cc1e1c--


--===============5827515891032788170==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
--===============5827515891032788170==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plone-i18n mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/plone-i18n

--===============5827515891032788170==--