Re: silvafind
eric casteleijn <[email protected]>
| Newsgroups | gmane.comp.web.zope.silva.devel |
|---|---|
| Message-ID | <[email protected]> |
> what about the performance impact because of this additional loop? i > guess (but i don't have any hard figures) that overall the search > results are presented faster because the second batch loop is smaller > and there are less conditions to be evaluated and less translations to > be made. The performance impact is not so much in the loop, as in that with this patch, every single object in the result set, not just in the batch, and that for every page view. The impact of this is so large that this is actually the reason that the Zope catalog returns brains, instead of the objects themselves. As to the security aspects, I totally agree that the current solution exposes more than we want to, but I see no immediate quick fix for this. A real solution would mean storing the permissions in the catalog, but since those are often acquired, we would need a pretty sophisticated event system to update the catalog to be able to do that. sorry, I would have liked to include the patch... As an aside, (and certainly not to downplay the potential security issues,) I *do* hope noone is storing passwords in plain text on any kind of web server. ;) -- - eric casteleijn http://infrae.com