Re: silva-2.2: comments

Andy Altepeter <[email protected]> Tue, 16 Jun 2009 21:09:54 -0500
Newsgroups gmane.comp.web.zope.silva.devel
Message-ID <[email protected]>
> > This locking appears to be non-functional in 2.1 and the trunk.
> > Quickly
> > grepping through Bethel's 2.0 in production, I'm not sure if it even
> > works
> > there since I can't find what I think I'm looking for.
> >
> > What version of Silva are you using where locking works?  And, does
> > locking
> > also work with kupu, or just the forms editor?  Does locking work
> > with other
> > versioned content objects as well?
>
> we have here Silva 1.5.13. locking is independent of editor used. i
> can only speak of silva documents. i think that i last saw or heard
> that the locking is working was two or three weeks ago.

Ok, I've finally tracked this down.  I ended up testing buildouts all the way 
back to the 1.5 branch, but none of the lock a document when editing in kupu.

I was able to cause a lock to be created by switching to the forms editor, and 
creating a paragraph (doing any action will suffice).  This then locked the 
document, so that accessing it as another user displayed the "locked" 
message.

I don't believe kupu, or any other type of content object for that matter, was 
ever designed to lock the object being edited.  This seems like a glaring 
omission -- an oversight that should be fixed.  I'm left wondering how this 
should be fixed.  There are a few options:

1) expand the locking mechanism on documents only, such that when kupu is 
loaded the document is also locked.  Ensure the lock is removed whenever the 
document is published.
2) expand the locking mechanism to all versioned content object's edit tab
3) expand the locking mechanism to all object's edit tab
And, in addition to the edit tab decision above:
A) expand locking mechanism for any tab which allow changing of content.  This 
would include (only?) the properties tab.

Thoughts?

Andy

>
> regards,
> marc