2.3: emailing chief editors in publication workflow

--===============4201738395652083164==
Content-Type: multipart/alternative; boundary=20cf303e9f26ad0ceb04aba8bb40

--20cf303e9f26ad0ceb04aba8bb40
Content-Type: text/plain; charset=ISO-8859-1

Greetings Devs,

One of our chief editors recently mentioned they were not receiving 'request
for approval' messages from her authors.  The messages service
(service_messages) is configured to "send emails when asked to".  My
service_mailhost does not have mail queuing enabled.

I've dug a bit in to why this does not work.  It appears that Silva 2.3 that
the 'request approval' button in the middleground is now in silva.core.smi
SMIAction (silva.core.smi.edit.content.RequestApproval).  Running through
the request approval process in my debugger, I see that the approval request
message is actually logged in service_messages:
RequestApproval calls Versioning.request_version_approval
Versioning.request_version_approval calls
Versioning._send_message_to_editors
Versioning._send_message_to_editors calls service_messages.send_message (to
the nearest chiefeditors)

The form action is now finished. The message service queues the message (it
does NOT send it immediately).

Looking in the legacy handlers for these actions, e.g.
Products.Silva.views.edit.VersionedContent.tab_status_request, the last
thing this handler does is to call service_messages.send_pending_messages.

It seems this behavior of calling send_pending_messages no longer happens in
the publication workflow in 2.3.  Is this a bug, or is there an alternative
means for sending pending messages which is preferred (e.g. calling
send_pending_messages via cron)?

Thanks,
Andy

--20cf303e9f26ad0ceb04aba8bb40
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Greetings Devs,<div><br></div><div>One of our chief editors recently mentio=
ned they were not receiving &#39;request for approval&#39; messages from he=
r authors. =A0The messages service (service_messages) is configured to &quo=
t;send emails when asked to&quot;. =A0My service_mailhost does not have mai=
l=A0queuing=A0enabled.</div>
<div><br></div><div>I&#39;ve dug a bit in to why this does not work. =A0It =
appears that Silva 2.3 that the &#39;request approval&#39; button in the mi=
ddleground is now in silva.core.smi SMIAction (silva.core.smi.edit.content.=
RequestApproval). =A0Running through the request approval process in my deb=
ugger, I see that the approval request message is actually logged in servic=
e_messages:</div>
<div>RequestApproval calls Versioning.request_version_approval</div><div>Ve=
rsioning.request_version_approval calls Versioning._send_message_to_editors=
</div><div>Versioning._send_message_to_editors calls service_messages.send_=
message (to the nearest chiefeditors)</div>
<div><br></div><div>The form action is now finished. The message service qu=
eues the message (it does NOT send it immediately).</div><div><br></div><di=
v>Looking in the legacy handlers for these actions, e.g. Products.Silva.vie=
ws.edit.VersionedContent.tab_status_request, the last thing this handler do=
es is to call service_messages.send_pending_messages.</div>
<div><br></div><div>It seems this behavior of calling send_pending_messages=
 no longer happens in the publication workflow in 2.3. =A0Is this a bug, or=
 is there an alternative means for sending pending messages which is prefer=
red (e.g. calling send_pending_messages via cron)?</div>
<div><br></div><div>Thanks,</div><div>Andy</div><meta http-equiv=3D"content=
-type" content=3D"text/html; charset=3Dutf-8">

--20cf303e9f26ad0ceb04aba8bb40--

--===============4201738395652083164==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
silva-dev mailing list
silva-dev-IAPFreCvJWM6s/[email protected]
https://lists.infrae.com/mailman/listinfo/silva-dev

--===============4201738395652083164==--