Re: 2.3: emailing chief editors in publication workflow

Op 13 sep 2011, om 03:53 heeft Andy Altepeter het volgende geschreven:

> Hi All,
> 
   Hello,

>> 
>> One of our chief editors recently mentioned they were not receiving
>> 'request for approval' messages from her authors.  The messages service
>> (service_messages) is configured to "send emails when asked to".  My
>> service_mailhost does not have mail queuing enabled.
>> 
>> I've dug a bit in to why this does not work.  It appears that Silva 2.3
>> that the 'request approval' button in the middleground is now in
>> silva.core.smi SMIAction (silva.core.smi.edit.content.RequestApproval).
>> Running through the request approval process in my debugger, I see that the
>> approval request message is actually logged in service_messages:
>> RequestApproval calls Versioning.request_version_approval
>> Versioning.request_version_approval calls
>> Versioning._send_message_to_editors
>> Versioning._send_message_to_editors calls service_messages.send_message (to
>> the nearest chiefeditors)
>> 
>> The form action is now finished. The message service queues the message (it
>> does NOT send it immediately).
>> 
>> Looking in the legacy handlers for these actions, e.g.
>> Products.Silva.views.edit.VersionedContent.tab_status_request, the last
>> thing this handler does is to call service_messages.send_pending_messages.
>> 
>> It seems this behavior of calling send_pending_messages no longer happens
>> in the publication workflow in 2.3.  Is this a bug, or is there an
>> alternative means for sending pending messages which is preferred (e.g.
>> calling send_pending_messages via cron)?
>> 

   No, this seems to be a bug.

   I will have a look today, as I will be porting optimizations for the sidebar to 2.3

   Sorry for the long reply.

   Regards,

  Sylvain,


-- 
Sylvain Viollon -- Infrae
t +31 10 243 7051 -- http://infrae.com
Hoevestraat 10 3033GC Rotterdam -- The Netherlands