Re: 2.3: emailing chief editors in publication workflow
Andrew Altepeter <[email protected]> Mon, 19 Sep 2011 14:40:18 -0500
| Newsgroups | gmane.comp.web.zope.silva.devel |
|---|---|
| Message-ID | <CAEssFdBOiVPwQz=6ibkYSaHjiPtBntjOyetRNV16fkO1GMsKoQ@mail.gmail.com> |
--===============3386896101588456816== Content-Type: multipart/alternative; boundary=20cf30050d72488ee904ad508329 --20cf30050d72488ee904ad508329 Content-Type: text/plain; charset=ISO-8859-1 Thanks Sylvain. I've pushed this out to our production servers, and will let the list know if we encounter any other issues with this. peace, Andy On Mon, Sep 19, 2011 at 8:12 AM, Sylvain Viollon <[email protected]> wrote: > > Op 15 sep 2011, om 09:50 heeft Sylvain Viollon het volgende geschreven: > > > > > Op 13 sep 2011, om 03:53 heeft Andy Altepeter het volgende geschreven: > > > >> Hi All, > >> > > Hello, > > > > Hello, > > >>> > >>> One of our chief editors recently mentioned they were not receiving > >>> 'request for approval' messages from her authors. The messages service > >>> (service_messages) is configured to "send emails when asked to". My > >>> service_mailhost does not have mail queuing enabled. > >>> > >>> I've dug a bit in to why this does not work. It appears that Silva 2.3 > >>> that the 'request approval' button in the middleground is now in > >>> silva.core.smi SMIAction (silva.core.smi.edit.content.RequestApproval). > >>> Running through the request approval process in my debugger, I see that > the > >>> approval request message is actually logged in service_messages: > >>> RequestApproval calls Versioning.request_version_approval > >>> Versioning.request_version_approval calls > >>> Versioning._send_message_to_editors > >>> Versioning._send_message_to_editors calls service_messages.send_message > (to > >>> the nearest chiefeditors) > >>> > >>> The form action is now finished. The message service queues the message > (it > >>> does NOT send it immediately). > >>> > >>> Looking in the legacy handlers for these actions, e.g. > >>> Products.Silva.views.edit.VersionedContent.tab_status_request, the last > >>> thing this handler does is to call > service_messages.send_pending_messages. > >>> > >>> It seems this behavior of calling send_pending_messages no longer > happens > >>> in the publication workflow in 2.3. Is this a bug, or is there an > >>> alternative means for sending pending messages which is preferred (e.g. > >>> calling send_pending_messages via cron)? > >>> > > > > No, this seems to be a bug. > > > > I will have a look today, as I will be porting optimizations for the > sidebar to 2.3 > > > > Sorry for the long reply. > > > > > This should be fixed in the default branch of silva.core.smi. > > Regards, > > Sylvain, > > -- > Sylvain Viollon -- Infrae > t +31 10 243 7051 -- http://infrae.com > Hoevestraat 10 3033GC Rotterdam -- The Netherlands > > > > _______________________________________________ > silva-dev mailing list > silva-dev-IAPFreCvJWM6s/[email protected] > https://lists.infrae.com/mailman/listinfo/silva-dev > --20cf30050d72488ee904ad508329 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks Sylvain.<div><br></div><div>I've pushed this out to our producti= on servers, and will let the list know if we encounter any other issues wit= h this.</div><div><br></div><div>peace,</div><div>Andy<br><br><div class=3D= "gmail_quote"> On Mon, Sep 19, 2011 at 8:12 AM, Sylvain Viollon <span dir=3D"ltr"><<a h= ref=3D"mailto:[email protected]">[email protected]</a>></span> wrote:<= br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left= :1px #ccc solid;padding-left:1ex;"> <br> Op 15 sep 2011, om 09:50 heeft Sylvain Viollon het volgende geschreven:<br> <div><div></div><div class=3D"h5"><br> ><br> > Op 13 sep 2011, om 03:53 heeft Andy Altepeter het volgende geschreven:= <br> ><br> >> Hi All,<br> >><br> > =A0 Hello,<br> ><br> <br> =A0 Hello,<br> <br> >>><br> >>> One of our chief editors recently mentioned they were not rece= iving<br> >>> 'request for approval' messages from her authors. =A0T= he messages service<br> >>> (service_messages) is configured to "send emails when ask= ed to". =A0My<br> >>> service_mailhost does not have mail queuing enabled.<br> >>><br> >>> I've dug a bit in to why this does not work. =A0It appears= that Silva 2.3<br> >>> that the 'request approval' button in the middleground= is now in<br> >>> silva.core.smi SMIAction (silva.core.smi.edit.content.RequestA= pproval).<br> >>> Running through the request approval process in my debugger, I= see that the<br> >>> approval request message is actually logged in service_message= s:<br> >>> RequestApproval calls Versioning.request_version_approval<br> >>> Versioning.request_version_approval calls<br> >>> Versioning._send_message_to_editors<br> >>> Versioning._send_message_to_editors calls service_messages.sen= d_message (to<br> >>> the nearest chiefeditors)<br> >>><br> >>> The form action is now finished. The message service queues th= e message (it<br> >>> does NOT send it immediately).<br> >>><br> >>> Looking in the legacy handlers for these actions, e.g.<br> >>> Products.Silva.views.edit.VersionedContent.tab_status_request,= the last<br> >>> thing this handler does is to call service_messages.send_pendi= ng_messages.<br> >>><br> >>> It seems this behavior of calling send_pending_messages no lon= ger happens<br> >>> in the publication workflow in 2.3. =A0Is this a bug, or is th= ere an<br> >>> alternative means for sending pending messages which is prefer= red (e.g.<br> >>> calling send_pending_messages via cron)?<br> >>><br> ><br> > =A0 No, this seems to be a bug.<br> ><br> > =A0 I will have a look today, as I will be porting optimizations for t= he sidebar to 2.3<br> ><br> > =A0 Sorry for the long reply.<br> ><br> <br> <br> </div></div> =A0 This should be fixed in the default branch of silva.core.s= mi.<br> <div class=3D"im"><br> =A0 Regards,<br> <br> =A0 Sylvain,<br> <br> --<br> Sylvain Viollon -- Infrae<br> t +31 10 243 7051 -- <a href=3D"http://infrae.com" target=3D"_blank">http:/= /infrae.com</a><br> Hoevestraat 10 3033GC Rotterdam -- The Netherlands<br> <br> <br> <br> </div><div><div></div><div class=3D"h5">___________________________________= ____________<br> silva-dev mailing list<br> <a href=3D"mailto:silva-dev-IAPFreCvJWM6s/[email protected]">silva-dev-IAPFreCvJWM6s/[email protected]</a= ><br> <a href=3D"https://lists.infrae.com/mailman/listinfo/silva-dev" target=3D"_= blank">https://lists.infrae.com/mailman/listinfo/silva-dev</a><br> </div></div></blockquote></div><br></div> --20cf30050d72488ee904ad508329-- --===============3386896101588456816== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ silva-dev mailing list silva-dev-IAPFreCvJWM6s/[email protected] https://lists.infrae.com/mailman/listinfo/silva-dev --===============3386896101588456816==--