Re: 2.3: emailing chief editors in publication workflow

Thanks for tracking that one down!

On 14 Oct 2011, at 17:53, Andy Altepeter wrote:

> Sylvain,
>
> It turns out there was an addition bug in messaging workflow.  While  =

> sending pending messages was actually happening, in Silva 2.3 the  =

> message service (service_messages) is always "disabled" even if the  =

> ZMI management screen shows it as "enabled".  On line 162 of  =

> Products.Silva.EmailMessageService.py, the name of the 'enabled'  =

> field is incorrect.  It is listed as '_enable', but in fact needs to  =

> be '_enabled'.
>
> I've adjusted this code in Products.Silva in the default branch and  =

> pushed it in to infrae's hg.  Not sure if this also needs to be  =

> pushed into the 3.0 branch.
>
> regards,
> Andy
>
> On Mon, Sep 19, 2011 at 2:40 PM, Andrew Altepeter  =

> <[email protected]> wrote:
> Thanks Sylvain.
>
> I've pushed this out to our production servers, and will let the  =

> list know if we encounter any other issues with this.
>
> peace,
> Andy
>
> On Mon, Sep 19, 2011 at 8:12 AM, Sylvain Viollon  =

> <[email protected]> wrote:
>
> Op 15 sep 2011, om 09:50 heeft Sylvain Viollon het volgende  =

> geschreven:
>
> >
> > Op 13 sep 2011, om 03:53 heeft Andy Altepeter het volgende  =

> geschreven:
> >
> >> Hi All,
> >>
> >   Hello,
> >
>
>   Hello,
>
> >>>
> >>> One of our chief editors recently mentioned they were not  =

> receiving
> >>> 'request for approval' messages from her authors.  The messages  =

> service
> >>> (service_messages) is configured to "send emails when asked  =

> to".  My
> >>> service_mailhost does not have mail queuing enabled.
> >>>
> >>> I've dug a bit in to why this does not work.  It appears that  =

> Silva 2.3
> >>> that the 'request approval' button in the middleground is now in
> >>> silva.core.smi SMIAction  =

> (silva.core.smi.edit.content.RequestApproval).
> >>> Running through the request approval process in my debugger, I  =

> see that the
> >>> approval request message is actually logged in service_messages:
> >>> RequestApproval calls Versioning.request_version_approval
> >>> Versioning.request_version_approval calls
> >>> Versioning._send_message_to_editors
> >>> Versioning._send_message_to_editors calls  =

> service_messages.send_message (to
> >>> the nearest chiefeditors)
> >>>
> >>> The form action is now finished. The message service queues the  =

> message (it
> >>> does NOT send it immediately).
> >>>
> >>> Looking in the legacy handlers for these actions, e.g.
> >>> Products.Silva.views.edit.VersionedContent.tab_status_request,  =

> the last
> >>> thing this handler does is to call  =

> service_messages.send_pending_messages.
> >>>
> >>> It seems this behavior of calling send_pending_messages no  =

> longer happens
> >>> in the publication workflow in 2.3.  Is this a bug, or is there an
> >>> alternative means for sending pending messages which is  =

> preferred (e.g.
> >>> calling send_pending_messages via cron)?
> >>>
> >
> >   No, this seems to be a bug.
> >
> >   I will have a look today, as I will be porting optimizations for  =

> the sidebar to 2.3
> >
> >   Sorry for the long reply.
> >
>
>
>   This should be fixed in the default branch of silva.core.smi.
>
>   Regards,
>
>   Sylvain,
>
> --
> Sylvain Viollon -- Infrae
> t +31 10 243 7051 -- http://infrae.com
> Hoevestraat 10 3033GC Rotterdam -- The Netherlands
>
>
>
> _______________________________________________
> silva-dev mailing list
> silva-dev-IAPFreCvJWM6s/[email protected]
> https://lists.infrae.com/mailman/listinfo/silva-dev
>
>
> _______________________________________________
> silva-dev mailing list
> silva-dev-IAPFreCvJWM6s/[email protected]
> https://lists.infrae.com/mailman/listinfo/silva-dev
>
>
> _______________________________________________
> silva-dev mailing list
> silva-dev-IAPFreCvJWM6s/[email protected]
> https://lists.infrae.com/mailman/listinfo/silva-dev



-- =

Kit BLAKE =B7 Infrae =B7 http://infrae.com/ + 31 10 243 7051