Re: Some structural improvements

Philipp von Weitershausen wrote:
> Toby Dickenson wrote:
> 
>>>Hello everyone,
>>>
>>>I've recently started looking into DirectoryStorage since I need to use
>>>it with Zope 3. Trying that has been a pretty smooth ride so far thanks
>>>to Toby's fixes for Zope 2.8/ZODB 3.4. Some smaller adjustments that I
>>>had to make to get it running have been made on the
>>>philikon-zope3-support-branch which is already waiting to be reviewed by
>>>Toby and then merged to the HEAD.
>>
>>Now merged.
> 
> Thanks!

I also disabled the assertion in DirectoryStorage.utils before the
class_name_from_pickle function for Python 2.4 compatability, as we
discussed earlier. This wasn't in the branch. I put a big comment there
reminding us to revise this point later (including the function).

>>>My last suggestion in the line structural improvements is to use a
>>>distutils-style setup. Most Python projects, whether tiny or big, have
>>>adopted the standard "setup.py install" method of installing themselves
>>>in a Python library directory, especially those that have C extensions
>>>(DirStorage has the readdir.c extension). With a distutils-style setup,
>>>you could say
>>>
>>> $ python setup.py install --home=/usr/local/Zope-2.8.1
>>>
>>>or for a Zope 3.1 instance
>>>
>>> $ python setup.py install --home=~/instances/zope31-w-dirstorage
>>>
>>>to compile and install DirStorage accordingly.
>>
>>
>>+1
> 
> Ok, I'll start my work on that then.

I have checked in a setup.py script replacing the simple compile.py that
was there before. The above commands are now just as easily possible as
inplace builds (the latter was what compile.py did). I added a
simplistic Makefile that provides a shortcut for those as well as
cleaning inplace builds.

Since I didn't do any reorgnization or other possibly harmful things, I
simply did this on the HEAD. I didn't update the docs yet because I'm
still waiting for the philikon-restify-docs-branch. Once we have a
(hopefully positive) decision regarding that, I will take care of the
docs, of course.

Philipp


-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php