Easy cleanups? (was Re: [dev] RFC IMVCCStorage everywhere (Move ZODB's MVCC to storage layer))
Jim Fulton <[email protected]>
| Newsgroups | gmane.comp.web.zope.zodb |
|---|---|
| Message-ID | <CAPDm-FiUrvXFMt6XiCpqttDyr+N8BGmw_O+UcJ5SCZt3Rd=aDw@mail.gmail.com> |
On Thu, Jun 16, 2016 at 6:34 AM, Julien Muchembled <[email protected]> wrote: ... > 3. deprecated stuff > > - getting rid off versions was already mentionned in PR 66, I'm ok with your answer Not sure what you're referring too, but I think you meant a different PR. I think getting rid of the version argument in a couple of places is relatively easy. I thought I was going to do that today. but it's more involved. In a number of cases: store, restore, and storeBlob, it's a bit harder. We can't just stop passing the argument. Someone needs to think about this and come up with a proposal. > - what about dropping the tpc_vote monkey-patch in DB.__init__ ? > similarly in Connection.tpc_vote, there's a "try ... except" on _storage.tpc_vote Given that these have had a deprecation warning forever, I think this is pretty straightforward. > - in Connection._store_objects, there's a TODO:deprecate then remove I think a deprecation warning needs to be added first. > - DB._storage Needs a deprecation warning. > - IStorageDB/IStorageWrapper ? This isn't annoying enough to change IMO. Jiim -- Jim Fulton http://jimfulton.info -- You received this message because you are subscribed to the Google Groups "zodb" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.