Re: Re: ZopeUndo.Prefix is still used

On Sun, Aug 14, 2016 at 9:04 AM, Hanno Schlichting <[email protected]>
wrote:

> Hi again.
>
> Looking into this a bit more, I changed the Zope2 code on master and
> dropped the ZopeUndo dependency.
>

Excellent.


>
> Undo management in Zope2 is now available in its ZMI control panel on
> each configured database object, instead of contextually on ZMI folders.
>


I'm not sure I understand this.  FWIW, if we need the ability to filter
undoLog/undoInfo at some point, I'd be happy to discuss some sort of
specification language based on data structures that don't require
instances.



> Hope this helps,
>

Yes it does.  I'm not going to drop support for ZopeUndo.Prefix right away
but it should be considered deprecated and doomed. I may add a deprecation
warning to ClientStorage.

Thanks.

Jim

On Sun, Aug 14, 2016, at 10:51, Hanno Schlichting wrote:
> > Hi.
> >
> > I saw Jim asking about the current state of ZopeUndo.Prefix.
> >
> > From what I can tell, it's still used - probably in the same way it has
> > been for a long time. The ZopeUndo.Prefix code these days lives in
> > https://github.com/zopefoundation/ZopeUndo/blob/
> master/src/ZopeUndo/Prefix.py.
> >
> > The code was split out into its own project, so that one could install
> > only this bit into a ZEO server Python environment, without pulling in
> > all of Zope2.
> >
> > On the Zope2 side, it's used from
> > https://github.com/zopefoundation/Zope/blob/master/src/App/Undo.py#L71,
> > specifically it calls storage.undoInfo with a Prefix-based specification
> > for both user_name and description and later calls storage.undoMultiple
> > with the resulting ids.
> >
> > We could simplify this on the Zope2 side, by simply dropping the
> > specification/filter and restrict the Undo ZMI page to only be available
> > on the ZMI root object, instead of being contextually available on each
> > ZMI folder.
> >
> > Would that help?
> >
> > Hanno
>
> --
> You received this message because you are subscribed to the Google Groups
> "zodb" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Jim Fulton
http://jimfulton.info

-- 
You received this message because you are subscribed to the Google Groups "zodb" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.