SVN: zope.testing/trunk/ attempt to fix bug when running subprocesses on Windows; I don't have

Benji York <[email protected]>
Newsgroups gmane.comp.web.zope.zope3.cvs
Message-ID <20090502164643.3FDCE941B1__3146.10221325911$1241282816$gmane$org@cvs.zope.org>
Log message for revision 99672:
  attempt to fix bug when running subprocesses on Windows; I don't have
  a Windows box to test this with
  

Changed:
  U   zope.testing/trunk/CHANGES.txt
  U   zope.testing/trunk/src/zope/testing/testrunner/runner.py

-=-
Modified: zope.testing/trunk/CHANGES.txt
===================================================================
--- zope.testing/trunk/CHANGES.txt	2009-05-02 10:11:59 UTC (rev 99671)
+++ zope.testing/trunk/CHANGES.txt	2009-05-02 16:46:42 UTC (rev 99672)
@@ -1,6 +1,12 @@
 zope.testing Changelog
 **********************
 
+3.7.5 (unreleased)
+==================
+
+- Fix bug when running subprocesses on Windows
+
+
 3.7.4 (2009-05-01)
 ==================
 

Modified: zope.testing/trunk/src/zope/testing/testrunner/runner.py
===================================================================
--- zope.testing/trunk/src/zope/testing/testrunner/runner.py	2009-05-02 10:11:59 UTC (rev 99671)
+++ zope.testing/trunk/src/zope/testing/testrunner/runner.py	2009-05-02 16:46:42 UTC (rev 99672)
@@ -403,7 +403,8 @@
             feature.layer_setup(layer)
 
         child = subprocess.Popen(args, shell=False, stdin=subprocess.PIPE,
-            stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True)
+            stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+            close_fds=not sys.platform.startswith('win'))
         subout, suberr = child.communicate()
 
         erriter = iter(suberr.splitlines())
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.