Re: z3c.form: handling of interface invariants
Michael Howitz <[email protected]> Tue, 30 Oct 2007 09:11:56 +0100
| Newsgroups | gmane.comp.web.zope.zope3 |
|---|---|
| Message-ID | <[email protected]> |
Am 09.10.2007 um 08:43 schrieb Michael Howitz: > Am 27.09.2007 um 10:37 schrieb Michael Howitz: >> After thinking it over we decided to implement the first approach =20 >> (change z3c.form.validator.Data to read the value of a field =20 >> missing in he form on the object). >> >> We put our changes into the branch gocept-invariants. >> >> The reasons to change our decision where the following: >> >> - the second approach (using save-points) requires save-point =20 >> support on the back-end and breaks without this support >> >> - using save-points would require to change the structure of =20 >> z3c.form: till now the complete validation is done by =20 >> z3c.form.field.FieldWidgets, using save-points validation gets =20 >> split up into validation of field contents in FieldWidgets and =20 >> validation of the invariants. >> The validation of the invariants has to be implemented at least =20 >> twice: in AddForm and EditForm because saving form values is done =20 >> completely different in these classes. So someone creating a =20 >> direct subclass of z3c.form.form.Form has to do things again or we =20= >> need additional changes in the structure. >> >> Any thoughts? > > As no-one had any further thoughts, I'll merge the branch into the =20 > trunk within the next few days. Done. Merged today. --=20 Mit freundlichen Gr=FC=DFen Michael Howitz gocept gmbh & co. kg =B7 forsterstrasse 29 =B7 06112 halle/saale www.gocept.com =B7 fon: +49 345 12298898 =B7 fax: +49 345 12298891