[PatchDiscussion] move access key help to help page

[email protected] (zwiki-repo)
Newsgroups gmane.comp.web.zope.zwiki
Message-ID <20080214204440.3445278001__13429.4350319125$1203021945$gmane$org@mail.joyful.com>
Thu Feb 14 12:41:14 PST 2008  Simon Michael <[email protected]>
  * move access key help to help page
diff -rN -u old-ZWiki/Makefile new-ZWiki/Makefile
--- old-ZWiki/Makefile	2008-02-14 12:44:39.000000000 -0800
+++ new-ZWiki/Makefile	2008-02-14 12:44:39.000000000 -0800
@@ -6,7 +6,7 @@
 # check for translations
 # check tests pass
 # check for late tracker issues
-# check showAccessKeys,README,wikis/,skins/,zwiki.org HelpPage,QuickReference
+# check README,wikis/,skins/,zwiki.org HelpPage,QuickReference
 # darcs changes --from-tag NN into CHANGES & edit; don't add header at top
 # update version.txt
 # make release
diff -rN -u old-ZWiki/plugins/__init__.py new-ZWiki/plugins/__init__.py
--- old-ZWiki/plugins/__init__.py	2008-02-14 12:44:39.000000000 -0800
+++ new-ZWiki/plugins/__init__.py	2008-02-14 12:44:39.000000000 -0800
@@ -17,7 +17,7 @@
 - dependencies in the Admin upgrade methods - resolved ?
 - issue tracker access key and link in wikipage template
 - tracker action in CMFInit fti
-- tracker hotkey in showAccessKeys
+- tracker access key
 - issue linking and link colouring in renderLink
 - isIssue arg support in pages
 - issue creation in mailin
diff -rN -u old-ZWiki/plugins/latexwiki/wikis/latexwiki/wikipage.pt new-ZWiki/plugins/latexwiki/wikis/latexwiki/wikipage.pt
--- old-ZWiki/plugins/latexwiki/wikis/latexwiki/wikipage.pt	2008-02-14 12:44:39.000000000 -0800
+++ new-ZWiki/plugins/latexwiki/wikis/latexwiki/wikipage.pt	2008-02-14 12:44:39.000000000 -0800
@@ -99,7 +99,6 @@
         <a tal:attributes="href python:here.nextPageUrl() or here.firstPageUrl()" accesskey="n"></a>
         <a tal:attributes="href python:here.previousPageUrl() or here.lastPageUrl()" accesskey="p"></a>
         <a tal:attributes="href here/upUrl" accesskey="u"></a>
-        <a tal:attributes="href string:${here/pageUrl}/showAccessKeys" accesskey="0"></a>
       </span>
 
       <!-- main links bar -->
diff -rN -u old-ZWiki/skins/zwiki/accesskeys.pt new-ZWiki/skins/zwiki/accesskeys.pt
--- old-ZWiki/skins/zwiki/accesskeys.pt	2008-02-14 12:44:39.000000000 -0800
+++ new-ZWiki/skins/zwiki/accesskeys.pt	2008-02-14 12:44:39.000000000 -0800
@@ -1,6 +1,4 @@
-<html>
-  <body>
-    <metal:block metal:define-macro="accesskeys"
+<metal:block metal:define-macro="accesskeys"
                  tal:define="pageurl here/pageUrl;
                              thisurl python:here.urlquote(request.get('URL'));
                              ">
@@ -28,7 +26,4 @@
       <a tal:attributes="href python:here.nextPageUrl() or here.firstPageUrl()" accesskey="n"></a>
       <a tal:attributes="href python:here.previousPageUrl() or here.lastPageUrl()" accesskey="p"></a>
       <a tal:attributes="href here/upUrl" accesskey="u"></a>
-      <a tal:attributes="href string:${here/pageUrl}/showAccessKeys" accesskey="0"></a>
     </metal:block>
-  </body>
-</html>
diff -rN -u old-ZWiki/skins/zwiki/HelpPage.stx new-ZWiki/skins/zwiki/HelpPage.stx
--- old-ZWiki/skins/zwiki/HelpPage.stx	2008-02-14 12:44:39.000000000 -0800
+++ new-ZWiki/skins/zwiki/HelpPage.stx	2008-02-14 12:44:39.000000000 -0800
@@ -34,10 +34,6 @@
 
   Some more tips:
 
-  - use the convenient 
-    "access keys":http://zwiki.org/QuickReference#access-keys for navigation
-    and other functions
-
   - set your time zone, editform height and other things by clicking "options"
 
   - leave your mouse pointer over most user interface elements to see
@@ -145,6 +141,54 @@
       try some tweaks; go to the docs or ask for help when you get really
       stuck or curious about why it's doing something.
 
+Access keys
+
+  Here are the access key shortcuts available on a zwiki site. 
+  See also http://zwiki.org/QuickReference#access-keys ::
+
+        wiki functions:
+
+        f    show front page
+        c    show wiki contents
+        r    show wiki recent changes
+             show discussion page
+        t    show issue tracker
+        i    show wiki index
+        o    show wiki options (preferences)
+        h    show help page
+        s    go to search field
+
+        page functions:
+
+        +    (in a plone/cmf site with skin switching set up) use zwiki's plone/cmf skin
+        -    (in a plone/cmf site with skin switching set up) use zwiki's standard skin
+        v    view page
+        m    mail subscription
+        b    show backlinks (links to this page)
+        d    show diffs (page edit history)
+        y    show full history (in ZMI)
+        e    edit this page
+        x    edit with an external editor
+             print this page (and subtopics)
+        q    view page source (quick-view)
+             wipe and regenerate this page's render cache
+             go to subtopics
+             go to comments (messages)
+             go to page author's home page, if possible
+        n    next page
+        p    previous page
+        u    up to parent page
+
+        when editing a page:
+
+        s    save changes
+        p    preview
+
+        when viewing page history:
+
+        n    next edit
+        p    previous edit
+
 Find out more
 
   About Zwiki: http://zwiki.org
diff -rN -u old-ZWiki/Views.py new-ZWiki/Views.py
--- old-ZWiki/Views.py	2008-02-14 12:44:39.000000000 -0800
+++ new-ZWiki/Views.py	2008-02-14 12:44:39.000000000 -0800
@@ -516,56 +516,6 @@
         """
         return self.getSkinTemplate('helppage')(self,REQUEST)
 
-    security.declareProtected(Permissions.View, 'showAccessKeys')
-    def showAccessKeys(self):
-        """
-        Show the access keys supported by the built-in skins.
-        """
-        return _("""
-        Access key reference (see also http://zwiki.org/QuickReference#access-keys)
-
-        0    show these access key assignments
-
-        wiki functions:
-        f    show front page
-        c    show wiki contents
-        r    show wiki recent changes
-             show discussion page
-        t    show issue tracker
-        i    show wiki index
-        o    show wiki options (preferences)
-        h    show help page
-        s    go to search field
-
-        page functions:
-        +    (in a plone/cmf site with skin switching set up) use zwiki's plone/cmf skin
-        -    (in a plone/cmf site with skin switching set up) use zwiki's standard skin
-        v    view page
-        m    mail subscription
-        b    show backlinks (links to this page)
-        d    show diffs (page edit history)
-        y    show full history (in ZMI)
-        e    edit this page
-        x    edit with an external editor
-             print this page (and subtopics)
-        q    view page source (quick-view)
-             wipe and regenerate this page's render cache
-             go to subtopics
-             go to comments (messages)
-             go to page author's home page, if possible
-        n    next page
-        p    previous page
-        u    up to parent page
-
-        in edit form:
-        s    save changes
-        p    preview
-
-        when viewing diffs:
-        n    next edit
-        p    previous edit
-        """)
-
     security.declareProtected(Permissions.View, 'stylesheet')
     def stylesheet(self, REQUEST=None):
         """

--
forwarded from http://zwiki.org/PatchDiscussion#[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.