[PatchDiscussion] drop the "discussion" nav link activated by GeneralDiscussion, it is a special case and confusable with per-page discussion

[email protected] (zwiki-repo)
Newsgroups gmane.comp.web.zope.zwiki
Message-ID <20080216225210.ABB3278006__40216.1509883173$1203202410$gmane$org@mail.joyful.com>
Sat Feb 16 14:49:56 PST 2008  Simon Michael <[email protected]>
  * drop the "discussion" nav link activated by GeneralDiscussion, it is a special case and confusable with per-page discussion
diff -rN -u old-ZWiki/skins/zwiki/links.pt new-ZWiki/skins/zwiki/links.pt
--- old-ZWiki/skins/zwiki/links.pt	2008-02-16 14:52:10.000000000 -0800
+++ new-ZWiki/skins/zwiki/links.pt	2008-02-16 14:52:10.000000000 -0800
@@ -38,11 +38,6 @@
          title="show wiki recent changes"
          i18n:attributes="title">
       <span i18n:translate="">changes</span></a>
-      <a href="" tal:attributes="href here/discussionUrl"
-         tal:condition="here/discussionUrl"
-         title="show discussion page"
-         i18n:attributes="title">
-      <span i18n:translate="">discussion</span></a>
       <a href="" tal:attributes="href here/trackerUrl"
          tal:condition="here/hasIssueTracker"
          title="show issue tracker"
diff -rN -u old-ZWiki/Utils.py new-ZWiki/Utils.py
--- old-ZWiki/Utils.py	2008-02-16 14:52:10.000000000 -0800
+++ new-ZWiki/Utils.py	2008-02-16 14:52:10.000000000 -0800
@@ -369,10 +369,7 @@
     def feedUrl(self):
         return self.defaultPageUrl() + '/pages_rss'
 
-    security.declareProtected(Permissions.View, 'discussionUrl')
-    def discussionUrl(self):
-        p = self.pageWithName('GeneralDiscussion')
-        return (p and p.pageUrl()) or ''
+    discussionUrl = defaultPageUrl
 
     security.declareProtected(Permissions.View, 'indexUrl')
     def indexUrl(self):

--
forwarded from http://zwiki.org/PatchDiscussion#[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.