[#1400] but,

Ugh, I need to read the full issue page. I see the diff was against a  
patched version, not Zwiki 0.60. Here's what happened I think:

- dejongm reported mail not going out to plone username subscribers  
with zwiki 0.60, plone 3

- kcleong reported the same issue with zwiki 0.59, plone 2.5, and said  
changing getattr to getProperty in emailAddressFrom fixed it

- delongm reported success with this fix and kindly posted the diff  
for others. Unfortunately the diff was backwards. :)

- cilugnedon reported the bug with zwiki 0.58, plone 2.5, and success  
with the the fix suggested here.

- sm got confused

Here is the fix I recommend. For greatest robustness, since we don't  
know the new way works with all older plones, this tries it both ways.

::

  ~/src/ZWiki$ darcs diff -u
  diff -rN -u old-ZWiki/Mail.py new-ZWiki/Mail.py
  --- old-ZWiki/Mail.py	2008-03-27 09:36:28.000000000 -0700
  +++ new-ZWiki/Mail.py	2008-03-27 09:36:28.000000000 -0700
  @@ -397,7 +397,7 @@
                   # NB doesn't work with CMFMember
                   if safe_hasattr(memberdata,'_members'):
                       member = memberdata._members.get(subscriber,None)
  -            email = getattr(member,'email','')
  +            email =  
member.getProperty('email',getattr(member,'email',''))
           else:
               email = ''
           return email.lower() or None

Now, how to get this into a release ? Remember that Zwiki <=0.59  
supports only Plone <=2.5 and Zwiki >=0.60 supports only Plone >=3.  
Also, in RoadMap2008 discussions we decided we are dropping Plone  
support in Zwiki 2. This would seem to imply that we need a Zwiki- 
plone2.5 and Zwiki-plone3 branch for legacy fixes like this. Yikes,  
complications. What to do ? 

--
forwarded from http://zwiki.org/1400EmailOutToPloneMembersNotWorking#[email protected]