[GeneralDiscussion] darcs send

Hi vejeta/zoperman, an update on this:

> I don't know why the patch didn't appear on GD

I haven't looked into this, but I know it wasn't working well (darcs  
patches made a mess of the wiki page) so I have changed the repo so  
darcs send forwards patches to me. I'll still use GeneralDiscussion  
for discussing patches. http://zwiki.org/DarcsRepos has been updated.

> ; nor why darcs won't accept the patch

This seems to be a darcs bug, reported as http://bugs.darcs.net/issue1335 
  .

I was able to work around the above, but the patch still does not  
apply in the stable repo; it says there are conflicts, and if I try to  
darcs apply --mark-conflicts darcs gives different error. Looks like  
another darcs bug or something wrong with the repo. Could you try  
doing a darcs pull in your repo to make sure you have the latest, and  
then do "darcs send" again.

Next, a little patch review: I see you've added the uid keyword  
argument to the catalog_object call in rating.py. I expect this was  
needed for your version of Plone (what version do you have ?) Do you  
know if this will work with other Plone versions ? Zwiki 0.61 is  
supposed to work with all versions of Plone 3, and I think Plone 2.5.  
It would be good to hear the code was tested with these versions, or  
that you researched a bit and think the risk is low.

This is a lot of work for a one-line fix, so if it's too much hassle  
don't worry about it. Your patch may also be highlighting some changes  
we need to make in the process, which is also valuable.


--
forwarded from http://zwiki.org/GeneralDiscussion#[email protected]