Re: Bug found in bugfix :-)

On Sat, 11 Jul 2020 12:17:20 -0500
"Matthew D. Fuller" <[email protected]> wrote:

> On Fri, Jul 10, 2020 at 12:36:51AM +0200 I heard the voice of
> Carl Svensson, and lo! it spake thus:
> > 
> >   if(!bw) {
> >    sendEvent = true;
> >   }
> > 
> 
> (I assume you mean commenting out the whole thing, so sendEvent
> doesn't get set, rather than commenting just the conditional, so
> sendEvent _always_ gets set)

You assume correctly -- sorry for being unclear.


> 
> The if(bw) thing seems weird too.  From context, I guess that's just a
> obsure way of expressing "if 3dborders"?  I'll see what I can dig
> up...

Judging by the comment it's either for UseThreeDBorders or BorderWidth 0 combined with UsePPosition. 

> 
> The origin seems to be in r79, which lists it among the other things
> it pulled in as
> 
>     * Andys java fix

I guess it's a judgement call over whether Java 1.4's craziness or Firefox' craziness should be prioritized :)
On my part, I'm fine with applying a local personal patch to the source, because I never use Java.

-- 
Carl Svensson