[PATCH] Remove the start function and use eclipse:eclipse

--===============1631580992==
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=

Hello!

I wanted to use Eclipse without an imagefile, but I got an error (with
CMUCL and SBCL):
=====
luca@gismo:~$ eclipse
; Loading #P"/home/luca/Hacking/cvs/eclipse/load-eclipse.lisp".
;; Loading #P"/home/luca/Hacking/cvs/eclipse/config.lisp".
;; Loading #P"/home/luca/Hacking/cvs/eclipse/system.lisp".
;;; Loading #P"/usr/lib/cmucl/subsystems/clx-library.x86f".
[...]
;; Loading #P"/home/luca/Hacking/cvs/eclipse/eclipse.x86f".

Unknown keyword argument -- :DIE-ON-INIT-ERROR.
   [Condition of type KERNEL:SIMPLE-PROGRAM-ERROR]

Restarts:
  0: [ABORT] Skip remaining initializations.

Debug  (type H for help)

(C::%UNKNOWN-KEYWORD-ARGUMENT-ERROR :DIE-ON-INIT-ERROR)
=====

I dug for the error and I found that in the eclipse bin I have:

    ${exec_prefix}/bin/$lisp \
        --load /home/luca/Hacking/cvs/eclipse/load-eclipse.lisp \
        --eval "(start ${options})"

The problem is that in load-eclipse.lisp.in, the start function is
declared as (start &key display sm-client-id), thus not accepting
the option ":die-on-init-error t", which is the default.

It seems that the start function is used only when you want to start
Eclipse from the fasl files.  For that reason, I think the best thing
to do is to evaluate "(eclipse:eclipse ${options})" instead (exactly
as it's done for the imagefile).

The attached patch against the latest CVS (cvs diff -Nau) does it:

- remove the start function

- evaluate "(eclipse:eclipse ${options})" in the eclipse bin even when
  using the fasl files

- modify the eclipse function to output the error condition (untested,
  I didn't had any error for the moment)

It works with CMUCL and imagefile or fasl files.

In case I am wrong, please disregard this mail ;-)

Thx, bye,
Gismo / Luca


--=-=-=
Content-Type: application/octet-stream
Content-Disposition: attachment;
	filename=eclipse_no-start-function_20060102.patch.gz
Content-Transfer-Encoding: base64
Content-Description: Remove the start function and use eclipse:eclipse instead

H4sICJo3uUMAA2VjbGlwc2Vfbm8tc3RhcnQtZnVuY3Rpb25fMjAwNjAxMDIucGF0Y2gA7ZRtb9Mw
EMdf15/iFDqUNPOauE+rpUmdtoGKtCF1vKyEQuJshiwpjtsxqu6zYzcPS9MW0BDsDX5R1+e7/93J
v9w4Dtg3Cn4Sh/xmLhg6+fOFJmfXEPKIUWjPRPKZ+bLN/IjPUtb2F6lIksq5SHy4QIJJwdmCxzcg
1JbyJAb3yHVRwMMQsAd4DlhoS6VejPHTqeHCpSeAOE4PCKFdl3ZcwI5ajbWQbdsVZwLvvFg798Ht
UtKlPSdzRqMRYLffJ4fHYOf7aIQATidvr0+M5tJPBPuY3nPp366guTx7P7k4H09W7ezv1enlxWqq
3LPVXLKFF5XuU8PMm6f5DtPmMplJ1W66sqaGgYBFqeqsTDe+Gn/QwjpXlHhBJfX15GzV1jacix1F
PJ3Vck6VlkqbSk/IrWT289NMVfCzeww5AgSv0LhG4BGPXwxClXsvh8M6hsPNmjdAVIYG6cEb9imD
0e3Q3jEl/RLG4SaLa/8tHN0KjsTpaxqz7T+MfxfGqu6/hrGaey+MpFunkXQ3q9Y4Vg3V0ege006P
EqekUclpHDf8t3EkVRyJczhQOKptmOGolpkyGUIrUOGR99CCmEeWpa9MHkLAGU5izGMuMRMiEQWT
5q0XBxET2PfU05jagXsR/84gF4L0DqvKWCwxDyyEG+Y6HkwLzIOvcy4PLJXGLs3qqwq4fl1tVPph
Iu48Ca31NU7mcjaXLTAeTx8PDKg7PwkW5f2qoKzD+1sWg+dLvvAkw1Fyg56i9RHr51e+OWFb+L7A
2NtVw17iBnXgBrt70Nztumi4/QLArgaQOIrBEsDBmr+dcT/n0NX82eq3k1NoahEwRmpIjNrpQyrZ
3VrK0O+EoBgFOLui1ZS5TRGGsBmwcB5DNqXM11/Ywz4atwCuDxtaBBY7rSpsyynBbZBxDuPvslz4
F8XQkmsL/QB6iEum9AkAAA==
--=-=-=--

--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBDuT/YVAp7Xm10JmkRAknJAJ9YYNbUrsqHqlJU8VMttOqh8pk7dgCaAuke
sdirTQwVwdDr3MfAohIVCTE=
=nQkp
-----END PGP SIGNATURE-----
--==-=-=--

--===============1631580992==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
eclipse-devel site list
[email protected]
http://common-lisp.net/mailman/listinfo/eclipse-devel
--===============1631580992==--