Re: [E-devel] Enlightenment 0.25.1 small font issues

Alan Swanson <[email protected]> Fri, 14 Jan 2022 15:52:06 +0000
Newsgroups gmane.comp.window-managers.enlightenment.devel
Message-ID <[email protected]> 
> On Fri, Jan 14, 2022 at 7:01 AM Alan Swanson <[email protected]>
> wrote:
> > 
> > The problem is that setting DPI to anything other than 96 breaks
> > many applications and toolkits, not just font sizing but GUI
> > rendering breakage. Historical cruft unfortunately but you have
> > to deal with it.
> > 
> > Even the recent Xorg 21.1.2 release had to revert this type of
> > change;
> > https://cgit.freedesktop.org/xorg/xserver/commit/?id=35af1299e73483eaf93d913a960e1d1738bc7de6
> > 
> > I've personally patched Enlightenment 0.25 to fix commit
> > 4b87781bae4a6ea70e5b6f38683e7c2ea0fd2c27 "scaling - remove
> > custon x application dpi and move to central scaling" by
> > reverting to 96dpi by default.
> 
> Would you mind sharing your patch? Non-experts like myself who expect
> the GUI to simply 'just work' and not have to fiddle with extraneous
> settings would *really* appreciate it. Thank you in advance for your
> consideration.

Well, you don't have to apply the patch as you just can do the
following instead.

> > Also needed to go through Settings-Look-Scaling-Advanced and
> > then either unset "Set Application DPI" or adjust it to 96 to
> > update the existing saved setting.

But attached is the patch along with another patch I tried whilst
investigating the problem that reverts the default font size from 10
back to 12 if unset as this was an undocumented/unintended change in
the following commit.

https://git.enlightenment.org/core/enlightenment.git/commit/src/bin/e_xsettings.c?h=v-0.25.0&id=71b5cb3e7c963f10af9be66df958ac98e92f8042

-- 
Alan.

_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
enlightenment25-fix-font-scaling-revert-default-dpi-to-96.patch (text/x-patch, 2.4 KB) 
diff -ur enlightenment-0.25.1/data/config/default/e.src enlightenment-0.25.1-fixdpi/data/config/default/e.src
--- enlightenment-0.25.1/data/config/default/e.src	2022-01-03 00:52:26.000000000 +0000
+++ enlightenment-0.25.1-fixdpi/data/config/default/e.src	2022-01-14 14:17:42.226032071 +0000
@@ -186,7 +186,7 @@
   value "scale.base_dpi" int: 90;
   value "scale.use_dpi" uchar: 1;
   value "scale.use_custom" uchar: 0;
-  value "scale.xapp_base_dpi" int: 75;
+  value "scale.xapp_base_dpi" int: 96;
   value "scale.set_xapp_dpi" uchar: 1;
   value "show_cursor" uchar: 1;
   value "idle_cursor" uchar: 1;
diff -ur enlightenment-0.25.1/data/config/standard/e.src enlightenment-0.25.1-fixdpi/data/config/standard/e.src
--- enlightenment-0.25.1/data/config/standard/e.src	2022-01-03 00:52:26.000000000 +0000
+++ enlightenment-0.25.1-fixdpi/data/config/standard/e.src	2022-01-14 14:17:57.300024233 +0000
@@ -179,7 +179,7 @@
     value "scale.base_dpi" int: 90;
     value "scale.use_dpi" uchar: 0;
     value "scale.use_custom" uchar: 0;
-    value "scale.xapp_base_dpi" int: 75;
+    value "scale.xapp_base_dpi" int: 96;
     value "scale.set_xapp_dpi" uchar: 1;
     value "show_cursor" uchar: 1;
     value "idle_cursor" uchar: 1;
diff -ur enlightenment-0.25.1/data/config/tiling/e.src enlightenment-0.25.1-fixdpi/data/config/tiling/e.src
--- enlightenment-0.25.1/data/config/tiling/e.src	2022-01-03 00:52:26.000000000 +0000
+++ enlightenment-0.25.1-fixdpi/data/config/tiling/e.src	2022-01-14 14:18:11.373013785 +0000
@@ -179,7 +179,7 @@
     value "scale.base_dpi" int: 90;
     value "scale.use_dpi" uchar: 0;
     value "scale.use_custom" uchar: 0;
-    value "scale.xapp_base_dpi" int: 75;
+    value "scale.xapp_base_dpi" int: 96;
     value "scale.set_xapp_dpi" uchar: 1;
     value "show_cursor" uchar: 1;
     value "idle_cursor" uchar: 1;
diff -ur enlightenment-0.25.1/src/bin/e_config.c enlightenment-0.25.1-fixdpi/src/bin/e_config.c
--- enlightenment-0.25.1/src/bin/e_config.c	2022-01-03 00:52:26.000000000 +0000
+++ enlightenment-0.25.1-fixdpi/src/bin/e_config.c	2022-01-14 14:19:15.539959020 +0000
@@ -1804,7 +1804,7 @@
           CONFIG_VERSION_CHECK(34)
             {
                CONFIG_VERSION_UPDATE_INFO(34);
-               e_config->scale.xapp_base_dpi = 75;
+               e_config->scale.xapp_base_dpi = 96;
                e_config->scale.set_xapp_dpi = 1;
                e_config_save_queue();
             }
enlightenment25-revert-default-font-app-default-size-to-12.patch (text/x-patch, 771 B) 
xsettings - always use decimal for format for float prints
https://git.enlightenment.org/core/enlightenment.git/commit/src/bin/e_xsettings.c?h=v-0.25.0&id=71b5cb3e7c963f10af9be66df958ac98e92f8042

Appears to change default font to size 10 from 12.

--- enlightenment-0.25.1/src/bin/e_xsettings.c	2022-01-03 00:52:26.000000000 +0000
+++ enlightenment-0.25.1/src/bin/e_xsettings.c	2022-01-13 17:40:15.997331652 +0000
@@ -561,7 +561,7 @@
              const char *p;
 
              /* TODO better way to convert evas font sizes? */
-             if      (!size)      size  =   10; // default if not set
+             if      (!size)      size  =   12; // default if not set
              else if (size < 0)   size /=  -10; // in 1/10th units
 
              // limit sizes