[RFC] Fix window title format leak?

Dominik Vogt <[email protected]> Fri, 26 Nov 2021 01:17:42 +0100
Newsgroups gmane.comp.window-managers.fvwm.devel
Message-ID <[email protected]>
--kvItqqBg2bJQgQhx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Is this the proper fix?

Ciao

Dominik ^_^  ^_^

=2D-

Dominik Vogt

--kvItqqBg2bJQgQhx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Fix-window-title-format-leak.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 3a9d0d208969321c548fa6f5e93a6e0550088581 Mon Sep 17 00:00:00 2001
From: Dominik Vogt <[email protected]>
Date: Fri, 26 Nov 2021 01:14:17 +0100
Subject: [PATCH] Fix window title format leak.

=2D--
 fvwm/add_window.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fvwm/add_window.c b/fvwm/add_window.c
index efaead81..003ef1ea 100644
=2D-- a/fvwm/add_window.c
+++ b/fvwm/add_window.c
@@ -1785,6 +1785,8 @@ int setup_visible_names(FvwmWindow *fw, int what_cha=
nged)
 			&bits, fw, &style, False);
 		if ((changed_names & bits) || (force_update & 1))
 		{
+			if (fw->visible_name !=3D NoName)
+				free(fw->visible_name);
 			fw->visible_name =3D ext_name;
 			affected_titles |=3D 1;
 		}
=2D-
2.30.2


--kvItqqBg2bJQgQhx--