[ icewm-Bugs-3393557 ] Icons not displayed correctly

SourceForge.net <[email protected]> Thu, 18 Aug 2011 15:11:35 +0400
Newsgroups gmane.comp.window-managers.icewm.devel
Message-ID <[email protected]>
Bugs item #3393557, was opened at 2011-08-18 09:54
Message generated for change (Comment added) made by s_i_m
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100031&aid=3393557&group_id=31

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: icewm-1.3
Group: appearance
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Marcus Moeller (marcusmoeller76)
Assigned to: Nobody/Anonymous (nobody)
Summary: Icons not displayed correctly

Initial Comment:
I have upgraded my IceWM Installation to 1.3.7-1 (Debian package version) and noticed that some icons of applications like nautilus or gnome-terminal are not displayed correctly anymore (unknown application icon is shown, instead). They have been displayed correctly in the previous version (which was 1.3.7~pre2-1+b1).

I have also re-checked if it's an IceWM problem by using another panel (in this case tint2), where the icons are shown correctly.


----------------------------------------------------------------------

Comment By: Stanislav Maslovski (s_i_m)
Date: 2011-08-18 15:11

Message:
This is introduced in revision 1.27.2.11.2.14 by captnmark, Sun Oct 17
17:38:56 2010 UTC of wmclient.cc.

Unfortunately, this change was not done exactly in the same way I proposed
in https://sourceforge.net/mailarchive/message.php?msg_id=25125642 .
Namelly, in the current code the icon property is not read in full because
of the redundant check "bytes_remain == 0" in the while() loop. Also, the
current code still imposes the unneeded artificial limit for the icon size.

Can you please check that with the attached patch the icons are displayed
correctly?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100031&aid=3393557&group_id=31

------------------------------------------------------------------------------
Get a FREE DOWNLOAD! and learn more about uberSVN rich system, 
user administration capabilities and model configuration. Take 
the hassle out of deploying and managing Subversion and the 
tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2