[ icewm-Bugs-3469460 ] reserved identifier violation

SourceForge.net <[email protected]> Wed, 04 Jan 2012 08:17:38 -0800
Newsgroups gmane.comp.window-managers.icewm.devel
Message-ID <[email protected]>
Bugs item #3469460, was opened at 2012-01-04 08:17
Message generated for change (Tracker Item Submitted) made by elfring
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100031&aid=3469460&group_id=31

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: icewm-1.3
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Markus Elfring (elfring)
Assigned to: Nobody/Anonymous (nobody)
Summary: reserved identifier violation

Initial Comment:
I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source files. Some places will be found where names begin with two underscores or an underscore and an uppercase letter.

Examples:
- __WINMGR_H
  http://icewm.cvs.sourceforge.net/viewvc/icewm/icewm-1.2/src/WinMgr.h?revision=1.9&view=markup

- __WMDIALOG_H
  http://icewm.cvs.sourceforge.net/viewvc/icewm/icewm-1.2/src/wmdialog.h?revision=1.5&view=markup

This does not fit to the expected naming conventions of the C/C++ language standard.
https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100031&aid=3469460&group_id=31

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox