[ icewm-Patches-3471908 ] Removing support for _NET_WORKAERA.

Patches item #3471908, was opened at 2012-01-10 08:01
Message generated for change (Comment added) made by thefirstone
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300031&aid=3471908&group_id=31

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://me.yahoo.com/a/OrlM9Rxp ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Removing support for _NET_WORKAERA.

Initial Comment:
This patch remove support for _NET_WORKAERA. Although it is part of the ewmh standard, this hint is incompatible with dual heads (because it assume that the net work aera is rectangular, which is not the case). This cause problems with QT4 apps not displaying menus on the second screen. It is the equivalent of this corresponding patch for awesome, that have been accepted, see: https://awesome.naquadah.org/bugs/index.php?do=details&task_id=732#comment1756

----------------------------------------------------------------------

Comment By: Eduard Bloch (thefirstone)
Date: 2012-01-15 08:14

Message:
Sorry, that is not true for the patch data from pastebin (see below). Maybe
some invisible characters have been added or there is a mix of different
newlines, I don't know. Anyhow, if you say that those are all required
modifications I will just count on that. AFAICS it does compile and the Qt
menu bug is really solved afterwards (thank you very much). Unified version
(last chunk integrated manually) can be found at
http://pkg-icewm.alioth.debian.org/ignore_workarea_hints .

icewm-1.3.7 $ curl --silent http://pastebin.com/raw.php?i=wxJyeWMH | patch
-p1 --dry-run 
(Stripping trailing CRs from patch.)
patching file src/wmapp.cc
(Stripping trailing CRs from patch.)
patching file src/wmmgr.cc
(Stripping trailing CRs from patch.)
patching file src/wmmgr.h
(Stripping trailing CRs from patch.)
patching file src/yxapp.cc
patch unexpectedly ends in middle of line
patch: **** unexpected end of file in patch

You seem to some other diff toolset. My rediff (from GNU patchutils)
doesn't know -r and there is no dif but diff. And BTW, the usual way to
create public patches is using "diff -Nurd" (with or without -N).

----------------------------------------------------------------------

Comment By: https://me.yahoo.com/a/OrlM9Rxp ()
Date: 2012-01-15 05:37

Message:
The paste is correct (ouput of dif -rc) and is accepted by patch. It
effectvely ends at line 66. Just apply the patch and rediff -rc to convince
yourself.

----------------------------------------------------------------------

Comment By: Eduard Bloch (thefirstone)
Date: 2012-01-14 14:03

Message:
That paste looks incomplete, croped at line 66

----------------------------------------------------------------------

Comment By: https://me.yahoo.com/a/OrlM9Rxp ()
Date: 2012-01-10 08:15

Message:
Seems there is a problem with sourceforge to access the file. The patch is
available here: http://pastebin.com/wxJyeWMH

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300031&aid=3471908&group_id=31

------------------------------------------------------------------------------
RSA(R) Conference 2012
Mar 27 - Feb 2
Save $400 by Jan. 27
Register now!
http://p.sf.net/sfu/rsa-sfdev2dev2