Re: Minor issue when using alternate xkb groups
Tuomo Valkonen <[email protected]>
| Newsgroups | gmane.comp.window-managers.ion.general |
|---|---|
| Message-ID | <[email protected]> |
On 2008-05-24, Andreas Hübner <[email protected]> wrote: > I did have a very minor issue with ion3 when using alternate xkb groups. > You may want to read the bug report I filed in the DBTS, if you are > interested in this. > [http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=414974] I suppose that with regard to this problem, it suffices to apply KNOWN_MODIFIERS_MASK -- recently removed as redundant, so rollback -- in the 'ioncore_unmod' and such functions. They're merely used to check that all modifiers have been released. But we only have to care about those modifiers that we ourselves use; it doesn't matter if modifiers we don't know about are still held, because we shouldn't get to handle any repeated presses then, if it was a properly handled additional modifier -- and the vomit-inducing Xkb masks others anyway. (That is, if AltGr is both Mod3 and Mode_Switch, we never see the Mod3 -- or does it actually show it in events for grabs on it? *puke*, if it does.) -- Tuomo