Patch for ratpoison.el
Philip Hudson <[email protected]>
| Newsgroups | gmane.comp.window-managers.ratpoison.devel |
|---|---|
| Message-ID | <[email protected]> |
Fixes the function redefinition problem around 'ratpoison-info'. Potentially breaks existing client code. A function is bound to this symbol in each of ratpoison.el and (after macro expansion) ratpoison-cmd.el, but with different arity and semantics. The patch renames functions 'ratpoison-info' and 'ratpoison-command- info' in ratpoison.el to 'ratpoison-info-page' and 'ratpoison-command- info-page' respectively. The latter function did not have a clash, but I considered it helpful to maintain consistency in this way. I am completely ignorant of the scope of any potential knock-on impact of this change for existing users. I am a brand new ratpoison user so this Works For Me. It may be that changing the symbol generated in the macro in ratpoison-cmd.el instead would actually be Doing The Right Thing -- I don't have the perspective to tell. All I can tell is that that would result in two mods in nogaps.el, whereas the attached patch results in none, so that's what I went with. -- Phil Hudson PGP/GnuPG ID: 0x887DCA63 _______________________________________________ Ratpoison-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/ratpoison-devel
ratpoison-info.patch
(application/octet-stream, 695 B)
*** ratpoison.el 2009-04-19 19:46:35.000000000 +0100
--- /home/phil/Desktop/ratpoison/contrib/ratpoison.el 2009-04-19 11:23:14.000000000 +0100
***************
*** 187,196 ****
;; Documentation
! (defun ratpoison-info-page ()
"Call up the ratpoison info page."
(interactive)
(info "ratpoison"))
! (defun ratpoison-command-info-page ()
"Call up the info page listing the ratpoison commands."
(interactive)
--- 187,196 ----
;; Documentation
! (defun ratpoison-info ()
"Call up the ratpoison info page."
(interactive)
(info "ratpoison"))
! (defun ratpoison-command-info ()
"Call up the info page listing the ratpoison commands."
(interactive)