Re: [PATCH] do not refresh ratpoison.man.1 with --disable-maintainer-mode

Hi,

"Bernhard R. Link" <[email protected]> writes:

> To avoid files shipped in the tarball to be regenerated with
> --disable-maintainer-mode, add the magic marker so that in that case
> there are no prerequisites, so the file is never regenerated.

I see two cases where this change has an impact.
1. you received a tarball, you want to patch the mdoc manpage, then
   rebuild a tarball but you don't have mandoc.
   -> I won't help you do that.
2. you received a tarball, you want to patch the mdoc(7) manpage, but
   you want to install the man(7) manpage (really?).
   -> Just patch the already shipped man(7) manpage.

Instead, your patch makes me want to just kill - again - the
AM_MAINTAINER_MODE line in configure.ac.

I might use AM_MISSING_PROG though, to deal with those cases:

  tmp=`mktemp` &&   -Tman < ./ratpoison.mdoc.1 > "$tmp" &&  chmod 0644 "$tmp" &&  mv "$tmp" ./ratpoison.man.1
  /bin/sh: -Tman: not found

isn't exactly helpful.

diff --git a/configure.ac b/configure.ac
index 326502b..36867cb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -95,7 +95,7 @@ AC_SUBST([manpage_format])
 
 dnl Checks for programs.
 AC_PROG_CC
-AC_PATH_PROG([MANDOC], [mandoc])
+AM_MISSING_PROG([MANDOC], [mandoc])
 AC_ARG_VAR([MANDOC],
   [path to mandoc(1), only used when regenerating doc/ratpoison.man.1 \
    after editing doc/ratpoison.mdoc.1])


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE