bug in cmd_sfdump

Joshua Leners <[email protected]> Mon, 9 Jun 2014 19:32:03 -0400

Newsgroups	gmane.comp.window-managers.ratpoison.devel
Message-ID	<CALT76boOet0_1WaL-O16d-kYGbLc5ziW9OBZDQVeTe5OZm2ArA@mail.gmail.com>

Hello,

I believe there is a bug in cmd_sfdump. Specifically, the sbuf_chop() to
remove the trailing comma is *inside* the loop for concatenating frame
dumps.

I've attached a gitdiff patch.

Thanks for maintaining ratpoison!
Josh

_______________________________________________
Ratpoison-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/ratpoison-devel

sfdump.patch (text/x-patch, 434 B)

diff --git a/src/actions.c b/src/actions.c
index 6dfe56f..7579101 100644
--- a/src/actions.c
+++ b/src/actions.c
@@ -5560,8 +5560,8 @@ cmd_sfdump (int interactively UNUSED, struct cmdarg **args UNUSED)
           sbuf_concat (dump, screen_suffix);
           free (frameset);
         }
-      sbuf_chop (dump);
     }
+  sbuf_chop (dump);
   ret = cmdret_new (RET_SUCCESS, "%s", sbuf_get (dump));
   sbuf_free (dump);
   return ret;