pull request: minor refactoring
Jeff Abrahamson <[email protected]> Tue, 8 Jul 2014 00:15:54 +0200
| Newsgroups | gmane.comp.window-managers.ratpoison.devel |
|---|---|
| Message-ID | <CAM4Y7zy8Yb4sVLVY6xWPYoGyhieWGdoh-2UJ4ctCr+YEBgDkYw@mail.gmail.com> |
Trying to make sense of set_active_window_body(), I simplified the function a touch. Pull request attached. Jeff Abrahamson +33 6 24 40 01 57 +44 7920 594 255 <-- until 18 July only http://jeff.purple.com/ http://blog.purple.com/jeff/ _______________________________________________ Ratpoison-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/ratpoison-devel
0001-Refactor-duplicate-branches-of-if-into-a-single-bloc.patch
(text/x-patch, 2 KB)
From 06a3f96fe162e5aadb032c8b00b37815abbfec1d Mon Sep 17 00:00:00 2001 From: Jeff Abrahamson <[email protected]> Date: Mon, 7 Jul 2014 19:59:05 +0200 Subject: [PATCH] Refactor duplicate branches of if() into a single block with leading ?:. --- src/window.c | 34 +++++++++------------------------- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/src/window.c b/src/window.c index de9032a..9d784ea 100644 --- a/src/window.c +++ b/src/window.c @@ -467,34 +467,18 @@ set_active_window_body (rp_window *win, int force) /* With Xinerama, we can move a window over to the current screen; otherwise * we have to switch to the screen that the window belongs to. */ - if (rp_have_xinerama) + rp_screen *screen = (rp_have_xinerama ? current_screen() : win->scr); + /* use the intended frame if we can. */ + if (win->intended_frame_number >= 0) { - /* use the intended frame if we can. */ - if (win->intended_frame_number >= 0) - { - frame = screen_get_frame (current_screen(), win->intended_frame_number); - win->intended_frame_number = -1; - if (frame != current_frame()) - last_frame = current_frame(); - } - - if (!frame) - frame = screen_get_frame (current_screen(), current_screen()->current_frame); + frame = screen_get_frame (screen, win->intended_frame_number); + win->intended_frame_number = -1; + if (frame != current_frame()) + last_frame = current_frame(); } - else - { - /* use the intended frame if we can. */ - if (win->intended_frame_number >= 0) - { - frame = screen_get_frame (win->scr, win->intended_frame_number); - win->intended_frame_number = -1; - if (frame != current_frame()) - last_frame = current_frame(); - } - if (!frame) - frame = screen_get_frame (win->scr, win->scr->current_frame); - } + if (!frame) + frame = screen_get_frame (screen, screen->current_frame); if (frame->dedicated && !force) { -- 2.0.0.526.g5318336