Re: [PATCH] Show frame indicator on focus* invocations

--===============5910542008152797010==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Antoine Busque <[email protected]> writes:

> On Mon, Jul 3, 2017 at 11:58 PM, Jeremie Courreges-Anglas
> <[email protected]> wrote:
>>
>> [...]
>>
>> I like the idea, however... why the show_frame_indicator(0) ->
>> show_frame_indicator(1) changes below?
>>
>> Right now, if the focus{up,down,left,right} commands can't find an
>> appropriate frame, they'll stay silent if you are on a single-frame
>> screen.  I think it's nicer that way.
>>
>> The rest of the patch looks correct, but I think there is room to
>> simplify the handling of the frame indicator.  Could you please test
>> the diff below and report back?
>>
>
> You're right, I just tested that patch on my end and it works just as
> well, with the added bonus of being more consistent with existing
> ratpoison commands' behaviour of not displaying the frame indicator
> when staying on a single-frame screen.
>
> I definitely think you should merge your patch rather than mine.

I've just pushed this change on the master branch.

Thanks a lot,
-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEUTWSwa02UpMr393MDfp0rhUk5+4FAllieSgACgkQDfp0rhUk
5+66NQ/+LxP/kazXdGBLa87+wdZnc+GUl+wKjOAMno8WrFhcUmuWfpGaSBmkRwBA
rkTTqaFc7/JMKfr62EOJJf+xnRaFNWLsTXC44JTIJ8GL27xTunfvjCpApq6Ety2q
0ZkdiFma2dYDrj1TLsO/4lrYG7BOBqVWY+d+kqr82B/bL4kVo1NeNBB+YNgbXFW8
JEK8d/IY/+YgyCJrR4Tu4SoxiFC5qkxvh6jOt81AcjgCOg9VI4j7s6/5/VDieM2t
5h3fRgUNmCq5/ZawMdlOZ3WmExdm9RZ0Vpxbmc6BAnswIUzHFLJoegLxLP94mjxt
xK88oVMOr4irKOLOVGnZdDPbQGSZEeOQHpY4LAcfaqIVTDojUSTJIkDlxt61P6AN
rDmM3ussrT5oe5wsxSb/nepdDAcQ0d3Dqju5cxD21lG0SVAqCLnvGtplpmtHyTc3
fX93kxrtwvnWBgI4SCEVSO20JTlt4YOXRjutlPgkWuZ5LR8aGDGwSFso55Vtaw/0
L5RciR5MziSyxSHcAktSpwBC8fdARme6q97p0gncN6gMXE9l3D7qCJYdi2qAFQpb
7V+kUlAjS70owhfhoASEeNuSxThN3XBS/FAXbKdR7X9ysI7DbJ8wchhvUdAv4KJn
YJedSv3XDSdhyOnGl2czA2aukz4n7xjDQ+ZVDLGt70qdi8AsEn4=
=8TBD
-----END PGP SIGNATURE-----
--=-=-=--


--===============5910542008152797010==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ratpoison-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/ratpoison-devel

--===============5910542008152797010==--