[PATCH] Fix: don't draw help window beyond screen height

Antoine Busque <[email protected]> Thu, 21 Sep 2017 20:13:21 -0400
Newsgroups gmane.comp.window-managers.ratpoison.devel
Message-ID <[email protected]>
The current computation for the drawing of the help window uses the
value `s->top + s->height` as the bottom edge of the screen, even
though the y values of the help strings being drawn are already
relative to the top of the screen. This results in some help strings
being drawn beyond the true edge of the screen, and therefore cut off.

Simply using `s->height` corrects this issue, and the help window gets
drawn properly even on multi-screen setups with differently sized
screens.

Signed-off-by: Antoine Busque <[email protected]>
---
 src/actions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/actions.c b/src/actions.c
index e65ca0c..d80cf88 100644
--- a/src/actions.c
+++ b/src/actions.c
@@ -3716,7 +3716,7 @@ cmd_help (int interactive, struct cmdarg **args)
 
           y += FONT_HEIGHT (s);
           /* Make sure the next line fits entirely within the window. */
-          if (y + FONT_HEIGHT (s) >= (s->top + s->height))
+          if (y + FONT_HEIGHT (s) >= s->height)
             {
               if (drawing_keys)
                 {
-- 
2.14.1