Re: [PATCH] Update expose.pl to Work with 1.4.9

--===============1781457684904418288==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 13 2017, Fahri Cihan Demirci <[email protected]> wrote:
> Since after xrandr support was added, sdump returns current screen name,
> screen number, x-coordinate, y-coordinate, width, height and a boolean
> flag designating the active screen.
> This patch changes sdump parsing method in the expose.pl script to
> accommodate those changes.

This looks right.  But I wonder if we should really print the screen
name in sdump.  Or maybe we should print the screen name last, and print
a dummy name instead of nothing if we don't have xrandr.  The migration
path looks suboptimal now.

Cc'ing Mathieu since he's done most of the xrandr work.

Thoughts?

> ---
>  contrib/expose.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/expose.pl b/contrib/expose.pl
> index 0a7127e..4db326b 100644
> --- a/contrib/expose.pl
> +++ b/contrib/expose.pl
> @@ -41,7 +41,7 @@ my $frames_old =3D &rp('fdump'); chomp $frames_old;
>  my @r; # Sub-optimal way of grabbing screen x,y,w,h.
>=20=20
>  #fixed to use sdump
> -($_, $r[0], $r[1], $r[2], $r[3]) =3D split(/ /,&rp ('sdump'));
> +($_, $_, $r[0], $r[1], $r[2], $r[3], $_) =3D split(/ /,&rp ('sdump'));
>=20=20
>  my $ret =3D join(", ", &rp_split(\@xids, \&split, $n, \@r));

=2D-=20
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEUTWSwa02UpMr393MDfp0rhUk5+4FAloLGaMACgkQDfp0rhUk
5+4f3xAAq9CMFN6pfsFqUSvDeYlto77Yt5HZK2EbV66/hyT8mj8WYGpZe4Bmx4Az
ZkBKN/HvaAxP6pkLJg/CEe9ksPK/f+vIutCKpBSwoQJDLNLItcI9Xm1me+NjlSFl
tc/sYnkgjb7Xxk3SHEkO3fV/3/IQm37Wm9xjo0GKWjgpg/LNBZHpdcLZf00TsVlO
giqisJQ1LuvV2Y8xHdqDmBL7kWnZ6XGl5xB4W/cIpCb9geEsKdhm4+plLhGLCeu7
wp0EcfdP1f1v79cHFPWwGYwwIoeV2ASfQmiRcU4+BGN86OOaQ+CW8G5srdw6Setg
79n0tW4V+b3u1ymoTONoyJug6PoAFmcMP1lZvR2f+pehBWJO9gSizWlqIYoL4aF5
qSALL3mNTLejfrOC9vYQ39bNitZHVQe/fccKHO+3WHoXjImHu1sou0n1bxzi0w9t
YeyaY+2njQsFBx0VtGX46Cvi44fMGi5fPs2G1qOletEldL52OScb0eNapa/9Dmg4
L0jx+6DsbGFgY96TmPO0HPgRhYsIoIvtkB95u1pLoVKu4n3Us9fUMfvKWwZyVTsH
MyLjydFaVFpNtnPhGWRPTl7kN+XKWYSAP40ahTAP4zhl9jCGv9q3a/vKWJ1dX1Yz
korDdFeJeNytzjIqtSp66oO2wmN5iwxitEmOHrMfiKn1UixGb0s=
=SCo0
-----END PGP SIGNATURE-----
--=-=-=--


--===============1781457684904418288==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ratpoison-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/ratpoison-devel

--===============1781457684904418288==--