[STUMP] git-describe does not honor 0.9.8 tag

Daniel Borchmann <[email protected]>
Newsgroups gmane.comp.window-managers.stumpwm.devel
Message-ID <[email protected]>
Hi,

it seems that the 0.9.8 tag is not honored by git-describe, and thus
also not by Stump.  If I am on master, then I get

  $ git describe
  0.9.7-160-g67ff979

It seems that 0.9.8 is not an annotated tag, and thus is ignored by
git-describe.  To fix this one could do

  $ git describe --tags
  0.9.8-3-g67ff979

The attached patch fixed this issue for me.

Best,

  Daniel

-- 
Daniel Borchmann                                   http://daniel.kxpq.de
GPG (Mail)            0849 473E 6BF0 B504 DF0B  D640 455E 3610 01FF 778F
.
Please avoid sending me Word or PowerPoint attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html

_______________________________________________
Stumpwm-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/stumpwm-devel
0001-Make-git-describe-also-recognize-not-annotated-tags.patch (text/x-diff, 897 B)
From 11ba451fe25f414297017a78e208dd98f59af54e Mon Sep 17 00:00:00 2001
From: Daniel Borchmann <[email protected]>
Date: Mon, 24 Feb 2014 09:36:55 +0100
Subject: [PATCH] Make git-describe also recognize not-annotated tags

Signed-off-by: Daniel Borchmann <[email protected]>
---
 version.lisp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/version.lisp b/version.lisp
index 2dd301f..f9f050f 100644
--- a/version.lisp
+++ b/version.lisp
@@ -34,7 +34,7 @@
        (if git-dir
            (string-trim '(#\Newline)
                         (run-shell-command
-                         (format nil "GIT_DIR=~a git describe" git-dir) t))
+                         (format nil "GIT_DIR=~a git describe --tags" git-dir) t))
            (asdf:component-version sys)))
   " Compiled On "
   (format-expand *time-format-string-alist*
-- 
1.9.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.