Re: JAWIN Digest - 17 Aug 2004 to 18 Aug 2004 (#2004-77)

Hi Alex

[email protected] wrote:

> Morten,
>         attached is a patch to the jawinuserguide_dll.html, containing an
> overview (my understanding of it) of the instruction strings and the stack
> size. When you get a chance, please review it.

I think it looks great, so with a few minor changes, I have added it
together with a couple of additional sections to the
jawinuserguide_dll.html document. In the same "round" I (of course)
added your name to the contributers list, and added you as one of the
authors in the HTML-comment in the top of the jawinuserguide_dll.html
file together with your (slightly obfuscated) email address. If you
don't want your email address in the file, or if you want your polrtex
(at) users.sourceforge.net address instead, please feel free to update
the file.

You may wonder why I have wrapped the lines from your patch. I of course
know that this has no influence on the final HTML whether the lines are
wrapped or not, but it makes it a little easier to do changes in the
text later, without causing diff tools to mark the entire section as
changed (as most diff tools are line based).

  I am not 100% confident
> that there are no inaccuracies in the explanation, and I tried not to make
> it too detailed or involved. Next, I will probably try to go over all
> instruction strings and document some examples of their usage.

That sound really great, have you considered making these examples as
test-cases? Check the org.jawin.InstructionTest in the test-src branch
at the Java side, and the cpp/CallCOMUnitTest/instructionTests.cpp on
the native side. You should be able to run the tests with the "ant test"
target - please email me if you gets classpath problems, as it at least
needs junit.jar.

> Along these
> lines, I was wondering : why does the Transform.cpp use literals in the
> process() method, instead of using the pre-defined values from
> instructions.h ?

:-) - this is probably one of the parts of Jawin that needs a little
cleanup.

>
>         I am also working on a Parameters class that would automate &
> simplify most of the basic instruction string building, some of the
> marshalling of ints, strings, buffers, etc, and stack size calculations. I
> will provide that together with the generated structs from VJ++. For
> handling structs, my idea is to basically  extend the Struct classes
> created by VJ++ (which contain all data elements), and have the child
> class implement a predefined interface (e.g. JawinCStruct), which will
> define the operations that will be necessary for the Parameters class
> (e.g. marshal, marshallOut, size, token, etc).
>

Sounds exciting, although I am not sure I understand it 100%, but I am
looking forward to see the code.

Best Regards, and thanks for the effort you puts into Jawin.
Morten