Re: [PATCH] menu_widget.js

Alex Russell <[email protected]> Mon, 31 May 2004 12:39:50 +0900
Newsgroups gmane.comp.windows.devel.netwindows
Message-ID <[email protected]>
Hey Jerritt,

Thanks so much for the patch.

I'm in Japan right now and won't have a chance to apply this until I get 
back in a couple of days. Dee, Michael, can you test this out and commit 
it if it works correctly?

Thanks again for the patch. I'll keep you posted.

Regards

Jerritt Collord wrote:
> thanks,
> 
> Jerritt
> 
> 
> ------------------------------------------------------------------------
> 
> --- menu_widget-orig.js	Thu May 20 12:30:44 2004
> +++ menu_widget.js	Thu May 20 13:24:40 2004
> @@ -64,15 +64,15 @@
>  
>  	this.highlight = function(){
>  		with(this.domNode.style){
> -			if(this.isMenuVisible){
> -				borderStyle = "inset";
> -			}else{
> -				borderStyle = "outset";
> -			}
>  			__util__.setClass(this.domNode, "Menu-button-highlight-div");
>  			if(__config__.applyThemedStyles){
>  				borderWidth = "1px 2px 1px 2px";
>  				padding = "0px 4px 0px 4px";
> +                        	if(this.isMenuVisible){
> +                               	 	borderStyle = "inset";
> +                        	}else{
> +                               	 	borderStyle = "outset";
> +                        	}
>  			}
>  		}
>  	}
> @@ -80,8 +80,10 @@
>  	this.unHighlight = function(){
>  		if(!this.isMenuVisible){
>  			__util__.setClass(this.domNode, "Menu-button-div");
> -			this.domNode.style.borderStyle = 'none none none none';
> -			this.domNode.style.padding = "1px 6px 1px 6px";
> +			if(__config__.applyThemedStyles){
> +				this.domNode.style.borderStyle = 'none none none none';
> +				this.domNode.style.padding = "1px 6px 1px 6px";
> +			}
>  		}
>  	}
>  }
> @@ -260,7 +262,7 @@
>  		dn.style.backgroundColor = __theme__.getAttr("menu_hl_bgcolor");
>  		dn.style.color = __theme__.getAttr("menu_hl_font_color");
>  	}else{
> -		__util__.setClass(dNode, "Menu-item-highlight-div");
> +		__util__.setClass(dn, "Menu-item-highlight-div");
>  	}
>  }
>  
> @@ -269,7 +271,7 @@
>  		dn.style.backgroundColor = __theme__.getAttr("menu_bgcolor");
>  		dn.style.color = __theme__.getAttr("menu_font_color");
>  	}else{
> -		__util__.setClass(dNode, "Menu-item-div");
> +		__util__.setClass(dn, "Menu-item-div");
>  	}
>  }
>  
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> The netWindows developers list: [email protected]
> http://netwindows.org/mailman/listinfo/devel_netwindows.org


_______________________________________________
The netWindows developers list: [email protected]
http://netwindows.org/mailman/listinfo/devel_netwindows.org