Re: Pagination on MSSQL2005

The patch commited to NH-1340 fis NH-1340 or NH-1250 or both ?

2008/6/13 Will Shaver <[email protected]>:

> Fixed!
>
> I'm sure not a record for time taken per lines of code written, but perhaps
> a personal best. Patch uploaded to JIRA. All other tests passing. Bug was
> actually in the tokenizer for the MsSql2005Dialect file, it never exited a
> quoted state.
>
>  -Will
>
>
>
>
> On Thu, Jun 12, 2008 at 9:53 AM, Ayende Rahien <[email protected]> wrote:
>
>> Yes, they are.
>>
>>
>>
>> On Thu, Jun 12, 2008 at 7:50 PM, Will Shaver <[email protected]>
>> wrote:
>>
>>> In case I get some time to work on this, the two issues are:
>>>  NH-1250 and NH-1340
>>> right?
>>>
>>>   On Thu, Jun 12, 2008 at 9:43 AM, Ayende Rahien <[email protected]>
>>> wrote:
>>>
>>>> +1
>>>>
>>>>
>>>> On Thu, Jun 12, 2008 at 7:41 PM, Fabio Maulo <[email protected]>
>>>> wrote:
>>>>
>>>>> So, the decision is.
>>>>> Maintain  MsSql2005Dialect as is in NH2.0.x and try to fix the two
>>>>> issues if we have time or some good soul send us a patch.
>>>>> Right ?
>>>>>
>>>>>
>>>>>
>>>>> 2008/6/12 Ayende Rahien <[email protected]>:
>>>>>
>>>>>> SQL 2000 pagination is broken. You can't get 50 - 100 without loading
>>>>>> 100 results, etc.
>>>>>> As far as I know, NH-1250 and NH-1340<http://jira.nhibernate.org/browse/NH-1340>are the only ones that has this issue, and I think they are fixable.
>>>>>>
>>>>>>
>>>>>> On Thu, Jun 12, 2008 at 6:56 PM, Fabio Maulo <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> Probably....
>>>>>>> But in some cases if you try to do the same query and paginate it
>>>>>>> using the MsSql2000Dialect it work without problems.
>>>>>>> I know the have the AST parse can solve many problems and give us
>>>>>>> many other possibility but we don't have it. Please help me to take a
>>>>>>> decision for pagination using MsSql2005Dialect.
>>>>>>>
>>>>>>> Please, take a look to JIRA and verify if all problems not appear
>>>>>>> using MsSql2000Dialect... if so we can release MsSql2005Dialect in NH2.0.0GA
>>>>>>> but using the MsSql2000Dialect pagination. The actual version of
>>>>>>> MsSql2005Dialect can still the same but only in trunk.
>>>>>>> Thanks.
>>>>>>> Fabio.
>>>>>>>
>>>>>>> 2008/6/12 Ayende Rahien <[email protected]>:
>>>>>>>
>>>>>>> The problem is the same with the translator.
>>>>>>>> By the time we get to the dialect, we are handing it a string, and
>>>>>>>> it now need to start parsing that. Which isn't very nice.
>>>>>>>> The only solution that I see is AST, but I don't think we can make
>>>>>>>> it work for 2.0
>>>>>>>>
>>>>>>>> The problem is that there _isn't_ a nice way to do pagination in SQL
>>>>>>>> 2005.
>>>>>>>>
>>>>>>>>
>>>>>>>>   On Thu, Jun 12, 2008 at 6:11 PM, Fabio Maulo <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>>  Hi.
>>>>>>>>>
>>>>>>>>> Oren we must do something with the issues generated on pagination
>>>>>>>>> using MsSql2005Dialect.
>>>>>>>>> We have some issues about it and it is another "delicate" piece of
>>>>>>>>> code in NH (like classic/QueryTranslator).
>>>>>>>>>
>>>>>>>>> I would like to have a "stable" decision before NH2.0.0Beta1
>>>>>>>>> release (this WE I'm going to release 2.0.0Alpha2)
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Fabio Maulo
>>>>>>>>>
>>>>>>>>> -------------------------------------------------------------------------
>>>>>>>>> Check out the new SourceForge.net Marketplace.
>>>>>>>>> It's the best place to buy or sell services for
>>>>>>>>> just about anything Open Source.
>>>>>>>>> http://sourceforge.net/services/buy/index.php
>>>>>>>>> _______________________________________________
>>>>>>>>> Nhibernate-development mailing list
>>>>>>>>> [email protected]
>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> -------------------------------------------------------------------------
>>>>>>>> Check out the new SourceForge.net Marketplace.
>>>>>>>> It's the best place to buy or sell services for
>>>>>>>> just about anything Open Source.
>>>>>>>> http://sourceforge.net/services/buy/index.php
>>>>>>>> _______________________________________________
>>>>>>>> Nhibernate-development mailing list
>>>>>>>> [email protected]
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Fabio Maulo
>>>>>>>
>>>>>>> -------------------------------------------------------------------------
>>>>>>> Check out the new SourceForge.net Marketplace.
>>>>>>> It's the best place to buy or sell services for
>>>>>>> just about anything Open Source.
>>>>>>> http://sourceforge.net/services/buy/index.php
>>>>>>> _______________________________________________
>>>>>>> Nhibernate-development mailing list
>>>>>>> [email protected]
>>>>>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> -------------------------------------------------------------------------
>>>>>> Check out the new SourceForge.net Marketplace.
>>>>>> It's the best place to buy or sell services for
>>>>>> just about anything Open Source.
>>>>>> http://sourceforge.net/services/buy/index.php
>>>>>> _______________________________________________
>>>>>> Nhibernate-development mailing list
>>>>>> [email protected]
>>>>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Fabio Maulo
>>>>>
>>>>>
>>>>> -------------------------------------------------------------------------
>>>>> Check out the new SourceForge.net Marketplace.
>>>>> It's the best place to buy or sell services for
>>>>> just about anything Open Source.
>>>>> http://sourceforge.net/services/buy/index.php
>>>>> _______________________________________________
>>>>> Nhibernate-development mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>>>
>>>>>
>>>>
>>>>
>>>> -------------------------------------------------------------------------
>>>> Check out the new SourceForge.net Marketplace.
>>>> It's the best place to buy or sell services for
>>>> just about anything Open Source.
>>>> http://sourceforge.net/services/buy/index.php
>>>> _______________________________________________
>>>> Nhibernate-development mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>>
>>>>
>>>
>>> -------------------------------------------------------------------------
>>> Check out the new SourceForge.net Marketplace.
>>> It's the best place to buy or sell services for
>>> just about anything Open Source.
>>> http://sourceforge.net/services/buy/index.php
>>> _______________________________________________
>>> Nhibernate-development mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>>
>>>
>>
>> -------------------------------------------------------------------------
>> Check out the new SourceForge.net Marketplace.
>> It's the best place to buy or sell services for
>> just about anything Open Source.
>> http://sourceforge.net/services/buy/index.php
>> _______________________________________________
>> Nhibernate-development mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>>
>>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> Nhibernate-development mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/nhibernate-development
>
>


-- 
Fabio Maulo

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

_______________________________________________
Nhibernate-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/nhibernate-development