Re: fpit - fixes and passive-pen support

On Mon, Jan 31, 2005 at 09:33:40PM -0500, David M. Clay wrote:
>David Dawes wrote:
>>On Mon, Jan 31, 2005 at 03:41:05PM -0500, David M. Clay wrote:
>>
>>>Hello all.
>>>
>>>I am new at this, so please gently guide me through this wonderful 
>>>process of open-source coding.
>>>
>>>I just recently purchased a Stylistic 3400 and found the current fpit 
>>>driver did not support the passive pen of the 3400. So I modified the 
>>>current driver to support the passive pen.
>>>
>>>I am looking to have my changes added to the latest source tree. What is 
>>>the best was to have others test my changes on other systems with 
>>>different hardware, especially the active-pen models? I am pretty sure 
>>>that I have fixed several bugs that had to have affected the active-pen 
>>>systems as well, and I hope that I haven't broken anything. I don't have 
>>>access to any other Stylistic tablets so I am unable to test it myself. 
>>>The driver does work beautifully on my Stylistic 3400 though. Are there 
>>>any testers out there? Whats the best way for me to post the changes? Is 
>>>there a preferred style for diff patches? Is there a FAQ for this?
>>
>>
>>I don't recall seeing any feedback regarding this driver in the
>>past, and from your decsription it sounds like you've fixed some
>>real bugs and improved the driver.  I'd suggest submitting your
>>patches ('diff -u' format preferred), and we can look at getting
>>them in for the coming release.  You can either post them here, or
>>submit them via bugs.xfree86.org.
>>
>>If anyone here is using the fpit driver, particularly with an active pen
>>system, they should speak up now, and test your patches.
>>
>>David
>>_______________________________________________
>>Devel mailing list
>>[email protected]
>>http://XFree86.Org/mailman/listinfo/devel
>>
>>
>
>Okay, here is my patch for the whole fpit directory. I edited the man
>page and readme file to reflect the changes. You will need to apply the
>patch in the xc/programs/Xserver/hw/xfree86/input/fpit directory and
>specify -p1 option. Forgive me if everyone already knows how to figure
>that out (I didn't).

I'm committing your patch now.  Thanks for the submission.

David.